Bug 69806 - DFG JIT switch dfgConvert methods to use callOperation
Summary: DFG JIT switch dfgConvert methods to use callOperation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 17:34 PDT by Gavin Barraclough
Modified: 2011-10-10 18:03 PDT (History)
1 user (show)

See Also:


Attachments
The patch (7.09 KB, patch)
2011-10-10 17:35 PDT, Gavin Barraclough
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-10-10 17:34:35 PDT
This is the last one!
Comment 1 Gavin Barraclough 2011-10-10 17:35:35 PDT
Created attachment 110449 [details]
The patch
Comment 2 WebKit Review Bot 2011-10-10 17:38:43 PDT
Attachment 110449 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGOperations.h:91:  DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/dfg/DFGOperations.h:92:  DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2011-10-10 18:03:12 PDT
Fixed in r97117