Bug 69798 – Touch events should take page scale into account

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[John Knottenbelt]

Event coordinates are in CSS pixels, so they should take the page scaling into account when converting from PlatformTouchEvent coordinates (which is in screen pixels).

[John Knottenbelt]

Created attachment 110429 [details]
Patch

[Hajime Morrita]

Comment on attachment 110429 [details]
Patch

Please include the expectation file of added test.

[John Knottenbelt]

Created attachment 111313 [details]
Patch

[WebKit Review Bot]

Attachment 111313 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[John Knottenbelt]

Thanks for reviewing, Hajime. Expectations now included.

I also changed the test to be more similar to the test it is derived from, bringing the coordinates of the gesture closer together so that they are recognised as a click (rather than say, a swipe).

[John Knottenbelt]

The style bot had a wobbly on this day - there weren't any style problems detected by webkit-patch upload.

I'd really appreciate it if someone could review. 

Thanks.

[Fady Samuel]

(In reply to comment #6)
> The style bot had a wobbly on this day - there weren't any style problems detected by webkit-patch upload.
> 
> I'd really appreciate it if someone could review. 
> 
> Thanks.

I spoke to John, I am able to repo the bug locally on http://www-cs-students.stanford.edu/~eparker/files/maps/visualize_touch_events.html.

This looks like a good fix, IMHO.

Simon, could you please take a look at this? Thanks.

[Adam Barth]

Comment on attachment 111313 [details]
Patch

Looks reasonable.

[WebKit Review Bot]

Comment on attachment 111313 [details]
Patch

Clearing flags on attachment: 111313

Committed r97988: <http://trac.webkit.org/changeset/97988>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.