Bug 69779 - media/audio-data-url.html test broken on Lion
Summary: media/audio-data-url.html test broken on Lion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 13:36 PDT by Jer Noble
Modified: 2012-02-07 15:53 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.75 KB, patch)
2011-10-10 13:40 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2011-10-10 15:30 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-10-10 13:36:55 PDT
media/audio-data-url.html test broken on Lion
Comment 1 Jer Noble 2011-10-10 13:40:35 PDT
Created attachment 110393 [details]
Patch
Comment 2 Darin Adler 2011-10-10 14:16:26 PDT
Comment on attachment 110393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110393&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285
> +    if (!willUseProxy && ![[cocoaURL scheme] isEqualTo:@"data"]) {

We should not do a case-sensitive compare of a URL scheme. So instead of iEqualTo we need something that ignores case.
Comment 3 Jer Noble 2011-10-10 14:32:30 PDT
(In reply to comment #2)
> (From update of attachment 110393 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110393&action=review
> 
> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285
> > +    if (!willUseProxy && ![[cocoaURL scheme] isEqualTo:@"data"]) {
> 
> We should not do a case-sensitive compare of a URL scheme. So instead of iEqualTo we need something that ignores case.

I'll change this to a case insensitive compare.
Comment 4 Jer Noble 2011-10-10 15:30:36 PDT
Created attachment 110421 [details]
Patch
Comment 5 Eric Carlson 2011-10-10 17:44:32 PDT
Comment on attachment 110421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110421&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285
> +    if (!willUseProxy && ![[cocoaURL scheme] compare:@"data" options:NSCaseInsensitiveSearch]) {

Is there any reason to not use WebCore's protocolIs() or KURL's protocolIsData() instead?
Comment 6 Jer Noble 2012-02-07 15:46:45 PST
(In reply to comment #5)
> (From update of attachment 110421 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110421&action=review
> 
> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285
> > +    if (!willUseProxy && ![[cocoaURL scheme] compare:@"data" options:NSCaseInsensitiveSearch]) {
> 
> Is there any reason to not use WebCore's protocolIs() or KURL's protocolIsData() instead?

Nope.  Will do.
Comment 7 Jer Noble 2012-02-07 15:53:24 PST
Committed r107002: <http://trac.webkit.org/changeset/107002>