media/audio-data-url.html test broken on Lion
Created attachment 110393 [details] Patch
Comment on attachment 110393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110393&action=review > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285 > + if (!willUseProxy && ![[cocoaURL scheme] isEqualTo:@"data"]) { We should not do a case-sensitive compare of a URL scheme. So instead of iEqualTo we need something that ignores case.
(In reply to comment #2) > (From update of attachment 110393 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110393&action=review > > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285 > > + if (!willUseProxy && ![[cocoaURL scheme] isEqualTo:@"data"]) { > > We should not do a case-sensitive compare of a URL scheme. So instead of iEqualTo we need something that ignores case. I'll change this to a case insensitive compare.
Created attachment 110421 [details] Patch
Comment on attachment 110421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110421&action=review > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285 > + if (!willUseProxy && ![[cocoaURL scheme] compare:@"data" options:NSCaseInsensitiveSearch]) { Is there any reason to not use WebCore's protocolIs() or KURL's protocolIsData() instead?
(In reply to comment #5) > (From update of attachment 110421 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110421&action=review > > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285 > > + if (!willUseProxy && ![[cocoaURL scheme] compare:@"data" options:NSCaseInsensitiveSearch]) { > > Is there any reason to not use WebCore's protocolIs() or KURL's protocolIsData() instead? Nope. Will do.
Committed r107002: <http://trac.webkit.org/changeset/107002>