Bug 69759 - Shrink RenderLayer and ScrollableArea.
Summary: Shrink RenderLayer and ScrollableArea.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 07:14 PDT by Andreas Kling
Modified: 2011-10-10 07:51 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (9.78 KB, patch)
2011-10-10 07:16 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-10 07:14:08 PDT
SSIA.
Comment 1 Andreas Kling 2011-10-10 07:16:17 PDT
Created attachment 110356 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-10-10 07:18:32 PDT
Attachment 110356 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/RenderLayer.h:711:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/rendering/RenderLayer.h:726:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2011-10-10 07:44:05 PDT
Comment on attachment 110356 [details]
Proposed patch

Please add a comment on top of the bits about why this specific ordering is good to reduce likelihood of someone breaking it accidentally.
Comment 4 Andreas Kling 2011-10-10 07:51:38 PDT
Committed r97062: <http://trac.webkit.org/changeset/97062>