WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69751
Shrink RenderListItem on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69751
Summary
Shrink RenderListItem on 64-bit.
Andreas Kling
Reported
2011-10-10 03:44:52 PDT
We can pack one int member into the padding at the end of RenderBlock.
Attachments
Proposed patch
(1.15 KB, patch)
2011-10-10 03:45 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-10-10 03:45:47 PDT
Created
attachment 110345
[details]
Proposed patch
Kenneth Rohde Christiansen
Comment 2
2011-10-10 04:15:51 PDT
Comment on
attachment 110345
[details]
Proposed patch You want to change the initialization order as well: 41 RenderListItem::RenderListItem(Node* node) 42 : RenderBlock(node) 43 , m_marker(0) 44 , m_hasExplicitValue(false) 45 , m_isValueUpToDate(false) 46 , m_notInList(false) 47 {
Kenneth Rohde Christiansen
Comment 3
2011-10-10 04:16:42 PDT
(In reply to
comment #2
)
> (From update of
attachment 110345
[details]
) > You want to change the initialization order as well: > > 41 RenderListItem::RenderListItem(Node* node) > 42 : RenderBlock(node) > 43 , m_marker(0) > 44 , m_hasExplicitValue(false) > 45 , m_isValueUpToDate(false) > 46 , m_notInList(false) > 47 {
Maybe not... I though I saw m_explicitValue here.
Andreas Kling
Comment 4
2011-10-10 04:28:54 PDT
Comment on
attachment 110345
[details]
Proposed patch Clearing flags on attachment: 110345 Committed
r97054
: <
http://trac.webkit.org/changeset/97054
>
Andreas Kling
Comment 5
2011-10-10 04:29:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug