Bug 69751 - Shrink RenderListItem on 64-bit.
Summary: Shrink RenderListItem on 64-bit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 03:44 PDT by Andreas Kling
Modified: 2011-10-10 04:29 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.15 KB, patch)
2011-10-10 03:45 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-10 03:44:52 PDT 
We can pack one int member into the padding at the end of RenderBlock.
Comment 1 Andreas Kling 2011-10-10 03:45:47 PDT 
Created attachment 110345 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2011-10-10 04:15:51 PDT 
Comment on attachment 110345 [details]
Proposed patch

You want to change the initialization order as well:

41	RenderListItem::RenderListItem(Node* node)
42	    : RenderBlock(node)
43	    , m_marker(0)
44	    , m_hasExplicitValue(false)
45	    , m_isValueUpToDate(false)
46	    , m_notInList(false)
47	{
Comment 3 Kenneth Rohde Christiansen 2011-10-10 04:16:42 PDT 
(In reply to comment #2)
> (From update of attachment 110345 [details])
> You want to change the initialization order as well:
> 
> 41    RenderListItem::RenderListItem(Node* node)
> 42        : RenderBlock(node)
> 43        , m_marker(0)
> 44        , m_hasExplicitValue(false)
> 45        , m_isValueUpToDate(false)
> 46        , m_notInList(false)
> 47    {

Maybe not... I though I saw m_explicitValue here.
Comment 4 Andreas Kling 2011-10-10 04:28:54 PDT 
Comment on attachment 110345 [details]
Proposed patch

Clearing flags on attachment: 110345

Committed r97054: <http://trac.webkit.org/changeset/97054>
Comment 5 Andreas Kling 2011-10-10 04:29:04 PDT 
All reviewed patches have been landed.  Closing bug.