Bug 69749 - [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable
Summary: [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 03:18 PDT by Philippe Normand
Modified: 2011-10-11 10:16 PDT (History)
1 user (show)

See Also:

Attachments
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749 (5.03 KB, patch)
2011-10-11 09:11 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-10-10 03:18:27 PDT 
GtkTable has been deprecated in GTK+3.
Comment 1 Claudio Saavedra 2011-10-11 09:11:40 PDT 
Created attachment 110521 [details]
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749

Reviewed by NOBODY (OOPS!).

* platform/gtk/GtkAuthenticationDialog.cpp:
(WebCore::addEntryToGrid): Migrate to GtkGrid when using GTK+ 3
(WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
Ditto.
Comment 2 Martin Robinson 2011-10-11 09:54:35 PDT 
Comment on attachment 110521 [details]
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749

Hopefully this will look better once we remove GTK+ support. :)
Comment 3 WebKit Review Bot 2011-10-11 10:16:03 PDT 
Comment on attachment 110521 [details]
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749

Clearing flags on attachment: 110521

Committed r97161: <http://trac.webkit.org/changeset/97161>
Comment 4 WebKit Review Bot 2011-10-11 10:16:07 PDT 
All reviewed patches have been landed.  Closing bug.