WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
UNCONFIRMED
69730
[GTK] Misnamed argument inverts semantics
https://bugs.webkit.org/show_bug.cgi?id=69730
Summary
[GTK] Misnamed argument inverts semantics
Bob Murphy
Reported
2011-10-09 13:31:47 PDT
In WebKitGtk 1.4.2, WebKitDomNode.cpp, the function webkit_dom_node_add_event_listener() accepts a "bubble" argument, and passes it unchanged to WebCore::GObjectEventListener::addEventListener(). However, the implementation of addEventListener(), in GObjectEventListener.h, has a "useCapture" argument at that same position. And digging past that, it does appear that argument means whether to fire the handler during the capture phase. Xan Lopez confirmed this, and suggested submitting a patch to make the parameter name consistent with what it actually accomplishes, which I will do.
Attachments
Add attachment
proposed patch, testcase, etc.
Alberto Garcia
Comment 1
2013-09-18 10:24:14 PDT
Ping
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug