Bug 69728 - CSP should log unrecognized directives to the console
: CSP should log unrecognized directives to the console
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Adam Barth
:
Depends on:
Blocks: 53572
  Show dependency treegraph
 
Reported: 2011-10-09 13:15 PDT by WebKit Review Bot
Modified: 2011-10-09 18:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.69 KB, patch)
2011-10-09 14:30 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (9.67 KB, patch)
2011-10-09 15:18 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (21.83 KB, patch)
2011-10-09 17:07 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-10-09 13:15:04 PDT
CSP should log unrecognized directives to the console
Requested by abarth on #webkit.
Comment 1 Adam Barth 2011-10-09 14:30:35 PDT
Created attachment 110311 [details]
Patch
Comment 2 Sam Weinig 2011-10-09 15:08:03 PDT
Comment on attachment 110311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110311&action=review

> Source/WebCore/page/ContentSecurityPolicy.h:80
> +    void reportUnrecognizedDirective(const String& name) const;

I am not thrilled with using the word report here, as it has a subtle implication that it will have the same semantics as reportViolation, sending the report to the server.
Comment 3 Adam Barth 2011-10-09 15:16:05 PDT
(In reply to comment #2)
> (From update of attachment 110311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110311&action=review
> 
> > Source/WebCore/page/ContentSecurityPolicy.h:80
> > +    void reportUnrecognizedDirective(const String& name) const;
> 
> I am not thrilled with using the word report here, as it has a subtle implication that it will have the same semantics as reportViolation, sending the report to the server.

Perhaps logUnrecognizedDirective ?
Comment 4 Adam Barth 2011-10-09 15:18:10 PDT
Created attachment 110312 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-10-09 16:22:11 PDT
Comment on attachment 110312 [details]
Patch for landing

Rejecting attachment 110312 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ause.html = MISSING PASS


Regressions: Unexpected text diff mismatch : (1)
  http/tests/security/contentSecurityPolicy/directive-parsing.html = TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/9995864
Comment 6 Adam Barth 2011-10-09 17:07:06 PDT
Created attachment 110313 [details]
Patch for landing
Comment 7 WebKit Review Bot 2011-10-09 18:14:30 PDT
Comment on attachment 110313 [details]
Patch for landing

Clearing flags on attachment: 110313

Committed r97035: <http://trac.webkit.org/changeset/97035>
Comment 8 WebKit Review Bot 2011-10-09 18:14:34 PDT
All reviewed patches have been landed.  Closing bug.