Bug 69726 - Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
Summary: Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-09 12:09 PDT by Pavel Feldman
Modified: 2011-10-10 10:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (99.59 KB, patch)
2011-10-09 12:19 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (110.44 KB, patch)
2011-10-10 07:44 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-09 12:09:53 PDT 
This change adds types to the DOMAgent and Debugger model. Besides the comments, it introduces WebInspector.Event (the one user in WebInspector.Object); spits the returnByValue and non-returnByValue evaluate paths.
Comment 1 Pavel Feldman 2011-10-09 12:19:13 PDT 
Created attachment 110306 [details]
Patch
Comment 2 Adam Barth 2011-10-09 14:39:26 PDT 
Comment on attachment 110306 [details]
Patch

This patch is causing the cr-linux-ews to spin.
Comment 3 Pavel Feldman 2011-10-10 07:44:17 PDT 
Created attachment 110358 [details]
Patch
Comment 4 Yury Semikhatsky 2011-10-10 08:33:26 PDT 
Comment on attachment 110358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110358&action=review

> Source/WebCore/inspector/front-end/DebuggerModel.js:389
> +        this._debuggerModel._parsedScriptSource(scriptId, sourceURL, startLine, startColumn, endLine, endColumn, isContentScript || false);

!!isContentScript ?

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:573
> +WebInspector.PresentationConsoleMessage.prototype = {

Remove this ?
Comment 5 Pavel Feldman 2011-10-10 10:02:17 PDT 
Committed r97067: <http://trac.webkit.org/changeset/97067>