Bug 69715 - Do not compare the first glyph to itself in Font::drawGlyphBuffer()
Summary: Do not compare the first glyph to itself in Font::drawGlyphBuffer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-08 22:28 PDT by Benjamin Poulain
Modified: 2011-10-09 02:59 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2011-10-08 22:38 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-10-08 22:28:36 PDT
In Font::drawGlyphBuffer():
1) the information of the first glyph is extracted
2) it is compared to itself, which never fails
3) then to the following glyphs are handled

We can just skip the first iteration which make the code a bit easier to read and hopefully a tiny-little-bit faster :)
Comment 1 Benjamin Poulain 2011-10-08 22:38:13 PDT
Created attachment 110290 [details]
Patch
Comment 2 Andreas Kling 2011-10-09 01:55:51 PDT
Comment on attachment 110290 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2011-10-09 02:59:17 PDT
Comment on attachment 110290 [details]
Patch

Clearing flags on attachment: 110290

Committed r97023: <http://trac.webkit.org/changeset/97023>
Comment 4 WebKit Review Bot 2011-10-09 02:59:21 PDT
All reviewed patches have been landed.  Closing bug.