Bug 69713 - run-webkit-tests should accept --child-processes
Summary: run-webkit-tests should accept --child-processes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
Depends on:
Reported: 2011-10-08 18:48 PDT by Ojan Vafai
Modified: 2011-10-15 17:17 PDT (History)
4 users (show)

See Also:

Patch (1.74 KB, patch)
2011-10-15 15:14 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (1.56 KB, patch)
2011-10-15 16:09 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-10-08 18:48:42 PDT
It lists --child-processes as a valid commandline argument, but it always creates 1 process. I think this is a regression. It's fine to default to 1, but if you pass the flag, it should respect it.

I had noticed recently the run-webkit-tests was taking forever even when I'd run with multiple child processes. I expect I might not be the only one surprised by this.
Comment 1 Eric Seidel (no email) 2011-10-09 08:55:38 PDT
That would be an odd regression.  I'll look on monday, now that I'm done with the CSS regression stuff.

If you run "new-run-webkit-tests" directly does child-processes work as you expect?  the "run-webkit-tests" wrapper overrides --child-process to 1.
Comment 2 Ojan Vafai 2011-10-09 19:07:25 PDT
It works correctly if I just new-run-webkit-tests directly.
Comment 3 Eric Seidel (no email) 2011-10-10 00:37:03 PDT
OK.  Should be easy to teach the wrapper to avoid overriding you.  But we could also mark this wontfix.  I'm working on NRWT again as of tomorrow.   Done with CSS regression distractions.
Comment 4 Ojan Vafai 2011-10-15 15:14:28 PDT
Created attachment 111151 [details]
Comment 5 Ojan Vafai 2011-10-15 15:15:22 PDT
Sorry if this perl is crap. I bet there's a simple one-liner for this. I'm just a perl noob.
Comment 6 Adam Barth 2011-10-15 15:56:37 PDT
Comment on attachment 111151 [details]

Check out usingWebKit2() and usingLeaks() for some ideas about how to do this more compactly.
Comment 7 Ojan Vafai 2011-10-15 16:09:01 PDT
Created attachment 111153 [details]
Comment 8 WebKit Review Bot 2011-10-15 17:17:34 PDT
Comment on attachment 111153 [details]

Clearing flags on attachment: 111153

Committed r97567: <http://trac.webkit.org/changeset/97567>
Comment 9 WebKit Review Bot 2011-10-15 17:17:38 PDT
All reviewed patches have been landed.  Closing bug.