Bug 69707 - Shrink RootInlineBox.
Summary: Shrink RootInlineBox.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-10-08 13:23 PDT by Andreas Kling
Modified: 2011-10-10 03:13 PDT (History)
3 users (show)

See Also:

Proposed patch (3.28 KB, patch)
2011-10-08 13:35 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Proposed patch (4.57 KB, patch)
2011-10-08 13:36 PDT, Andreas Kling
darin: review-
darin: commit-queue-
Details | Formatted Diff | Diff
Proposed patch v2 (5.58 KB, patch)
2011-10-10 01:50 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-08 13:23:25 PDT
There's some potential here.
Comment 1 Andreas Kling 2011-10-08 13:35:31 PDT
Created attachment 110279 [details]
Proposed patch
Comment 2 Andreas Kling 2011-10-08 13:36:21 PDT
Created attachment 110280 [details]
Proposed patch

Let's try again with a patch instead of a crashy SVG file..
Comment 3 WebKit Review Bot 2011-10-08 13:39:03 PDT
Attachment 110279 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Darin Adler 2011-10-09 19:33:07 PDT
Comment on attachment 110280 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110280&action=review

> Source/WebCore/rendering/InlineFlowBox.h:302
> +protected:

I don’t think you should restate “protected”. It’s OK but a little strange, since we don’t normally repeat these.

> Source/WebCore/rendering/InlineFlowBox.h:314
> +    WTF::Unicode::Direction m_lineBreakBidiStatusEor : 5;
> +    WTF::Unicode::Direction m_lineBreakBidiStatusLastStrong : 5;
> +    WTF::Unicode::Direction m_lineBreakBidiStatusLast : 5;

These need to be unsigned, not Direction, since Direction is an enum. It’s the same MSVC/enum/bitfield problem we have elsewhere. Also, probably don’t need the WTF:: prefix here because of the strange way WTF uses its namespace.

I know you just moved these members, but they will malfunction if the direction is a value with the high bit set. If the code worked OK on Windows before there’s a chance we could get away with 4-bit bitfields.
Comment 5 Andreas Kling 2011-10-10 01:50:30 PDT
Created attachment 110338 [details]
Proposed patch v2
Comment 6 Andreas Kling 2011-10-10 03:13:24 PDT
Comment on attachment 110338 [details]
Proposed patch v2

Clearing flags on attachment: 110338

Committed r97052: <http://trac.webkit.org/changeset/97052>
Comment 7 Andreas Kling 2011-10-10 03:13:33 PDT
All reviewed patches have been landed.  Closing bug.