Bug 69707 – Shrink RootInlineBox.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Andreas Kling]

There's some potential here.

[Andreas Kling]

Created attachment 110279 [details]
Proposed patch

[Andreas Kling]

Created attachment 110280 [details]
Proposed patch

Let's try again with a patch instead of a crashy SVG file..

[WebKit Review Bot]

Attachment 110279 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 110280 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110280&action=review

> Source/WebCore/rendering/InlineFlowBox.h:302
> +protected:

I don’t think you should restate “protected”. It’s OK but a little strange, since we don’t normally repeat these.

> Source/WebCore/rendering/InlineFlowBox.h:314
> +    WTF::Unicode::Direction m_lineBreakBidiStatusEor : 5;
> +    WTF::Unicode::Direction m_lineBreakBidiStatusLastStrong : 5;
> +    WTF::Unicode::Direction m_lineBreakBidiStatusLast : 5;

These need to be unsigned, not Direction, since Direction is an enum. It’s the same MSVC/enum/bitfield problem we have elsewhere. Also, probably don’t need the WTF:: prefix here because of the strange way WTF uses its namespace.

I know you just moved these members, but they will malfunction if the direction is a value with the high bit set. If the code worked OK on Windows before there’s a chance we could get away with 4-bit bitfields.

[Andreas Kling]

Created attachment 110338 [details]
Proposed patch v2

[Andreas Kling]

Comment on attachment 110338 [details]
Proposed patch v2

Clearing flags on attachment: 110338

Committed r97052: <http://trac.webkit.org/changeset/97052>

[Andreas Kling]

All reviewed patches have been landed.  Closing bug.