Bug 69700 - [Qt] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml fails
Summary: [Qt] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-10-08 05:56 PDT by Csaba Osztrogonác
Modified: 2011-10-09 03:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.33 KB, patch)
2011-10-08 23:05 PDT, Sergey Glazunov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-10-08 05:56:25 PDT
http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml introduced in 
http://trac.webkit.org/changeset/96984 (https://bugs.webkit.org/show_bug.cgi?id=69661),
but fails on the Qt bot:

--- /ramdisk/qt-linux-release/build/layout-test-results/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt 
+++ /ramdisk/qt-linux-release/build/layout-test-results/http/tests/security/xss-DENIED-xsl-document-securityOrigin-actual.txt 
@@ -1,3 +1,4 @@
-CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8080/security/resources/innocent-victim.html from frame with URL about:blank. Domains, protocols and ports must match.
-
-This test passes if it doesn't alert the contents of innocent-victim.html.  
+CONSOLE MESSAGE: line 2: <html xmlns='http://www.w3.org/1999/xhtml/'><body><p>Running an XSL-T 1.0 stylesheet with a 2.0 processor.</p></body></html>
+CONSOLE MESSAGE: line 2: <html xmlns='http://www.w3.org/1999/xhtml/'><body><p>Running an XSL-T 1.0 stylesheet with a 2.0 processor.</p></body></html>
+FAIL: Timed out waiting for notifyDone to be called
+This test passes if it doesn't alert the contents of innocent-victim.html. 

bug69661 is security bug, so I can't comment it, but I cc-ed the author 
(Sergey), the reviewer (Adam) and a member of security
group from Nokia (Tor Arne).

Could you check if it is a security problem on Qt or not?
Comment 1 Csaba Osztrogonác 2011-10-08 06:09:56 PDT
Skipped by http://trac.webkit.org/changeset/97008 until fix.
Comment 2 Adam Barth 2011-10-08 09:58:54 PDT
It's not a security problem.  The test is just timing out for some reason.
Comment 3 Sergey Glazunov 2011-10-08 23:05:14 PDT
Created attachment 110291 [details]
Patch
Comment 4 Adam Barth 2011-10-08 23:18:20 PDT
Thanks Sergey.
Comment 5 WebKit Review Bot 2011-10-09 00:22:35 PDT
Comment on attachment 110291 [details]
Patch

Clearing flags on attachment: 110291

Committed r97021: <http://trac.webkit.org/changeset/97021>
Comment 6 WebKit Review Bot 2011-10-09 00:22:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Sergey Glazunov 2011-10-09 01:21:40 PDT
Aw, it's failing again and the diff is nice:
--- /ramdisk/qt-linux-release/build/layout-test-results/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt 
+++ /ramdisk/qt-linux-release/build/layout-test-results/http/tests/security/xss-DENIED-xsl-document-securityOrigin-actual.txt 
@@ -1,3 +1,3 @@
 CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8080/security/resources/innocent-victim.html from frame with URL about:blank. Domains, protocols and ports must match.
 
-This test passes if it doesn't alert the contents of innocent-victim.html.  
+This test passes if it doesn't alert the contents of innocent-victim.html.
Comment 8 Csaba Osztrogonác 2011-10-09 03:15:12 PDT
Thanks for the fix. It seems the difference caused by a Qt-DRT bug, new bug report: https://bugs.webkit.org/show_bug.cgi?id=69718

And I added a Qt specific expected file to make our buildbot happy: http://trac.webkit.org/changeset/97024