RESOLVED FIXED Bug 69695
DFG JIT - only Array predictions can result in unboxed cells in register file 
https://bugs.webkit.org/show_bug.cgi?id=69695
Summary DFG JIT - only Array predictions can result in unboxed cells in register file
Yuqiang Xian
Reported 2011-10-07 23:34:25 PDT
In current DFG JIT, only array predictions can result in unboxed cells in register file, not for the other cell predictions.
Attachments
the patch (1.34 KB, patch)
2011-10-07 23:37 PDT, Yuqiang Xian 		fpizlo: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuqiang Xian
Comment 1 2011-10-07 23:37:44 PDT
Created attachment 110261 [details] the patch
WebKit Review Bot
Comment 2 2011-10-08 00:59:19 PDT
Comment on attachment 110261 [details] the patch Rejecting attachment 110261 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 4accce464c131e2674053eecb777610f8db053a3 r97004 = 258871568391186870681ec2bc7aff273b58b6cd Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10006415
Filip Pizlo
Comment 3 2011-10-08 01:00:41 PDT
(In reply to comment #2) > (From update of attachment 110261 [details]) > Rejecting attachment 110261 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > 4accce464c131e2674053eecb777610f8db053a3 > r97004 = 258871568391186870681ec2bc7aff273b58b6cd > Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc > First, rewinding head to replay your work on top of it... > Fast-forwarded master to refs/remotes/origin/master. > Updating chromium port dependencies using gclient... > > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > Updating webkit projects from gyp files... > > Full output: http://queues.webkit.org/results/10006415 Well that's annoying! I'll land manually.
Filip Pizlo
Comment 4 2011-10-08 01:15:13 PDT
Landed in r97005.
Note You need to log in before you can comment on or make changes to this bug.