Bug 69694 – PluginDocumentParser uses incorrect syntax for background color

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nico Weber]

PluginDocument: bgcolor doesn't support rgb() syntax

[Nico Weber]

Created attachment 110256 [details]
Patch

[Nico Weber]

This was last modified here: http://trac.webkit.org/changeset/24242

With this patch, this matches MediaDocument (see http://codesearch.google.com/codesearch#search/&exact_package=chromium&q=rgb%5C(38,38,38%5C)&type=cs ).

Found by ben.quar…@callmeqube.com: http://code.google.com/p/chromium/issues/detail?id=93168#c11

[Andreas Kling]

Comment on attachment 110256 [details]
Patch

Looks sane, but needs a test.

[Nico Weber]

The reason why this is happening now is because of http://trac.webkit.org/changeset/90139/trunk . With that, "rgb(38,38,38)" is converted to "0000380380380" -> "0000380380380" -> "00003 80380 38000" -> "#038038", which is the background green that's now visible for plugins.

[Nico Weber]

Created attachment 110275 [details]
Patch

[Nico Weber]

Created attachment 110276 [details]
Patch

[Nico Weber]

Comment on attachment 110276 [details]
Patch

expected files still missing, i'll add them soon

[Nico Weber]

Created attachment 110305 [details]
Patch

[Nico Weber]

This is http://crbug.com/93168

[Nico Weber]

Created attachment 110308 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 110308 [details]
Patch for landing

Rejecting attachment 110308 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
SS
  media/video-playing-and-pause.html = MISSING PASS


Regressions: Unexpected text diff mismatch : (1)
  plugins/iframe-plugin-bgcolor.html = TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/10015598

[Nico Weber]

Comment on attachment 110308 [details]
Patch for landing

can't repro that locally. trying again.

[WebKit Review Bot]

Comment on attachment 110308 [details]
Patch for landing

Rejecting attachment 110308 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
SS
  media/video-playing-and-pause.html = MISSING PASS


Regressions: Unexpected text diff mismatch : (1)
  plugins/iframe-plugin-bgcolor.html = TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/10009823

[Alexey Proskuryakov]

Bug title and description just say that "bgcolor doesn't support rgb() syntax", which doesn't seem to be what's fixed here.

Would "PluginDocumentParser uses incorrect syntax for background color" correctly describe the bug?

[Nico Weber]

Created attachment 110410 [details]
Patch for landing

[Nico Weber]

The document is 1px higher on linux for some reason, but the pixel test succeeds anyway. Trying with a platform-specific txt expectations file; I opened issue 69791 for getting win/linux baselines.

ap: Thanks, that's way better, done.

[WebKit Review Bot]

Comment on attachment 110410 [details]
Patch for landing

Rejecting attachment 110410 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Hunk #1 FAILED at 3838.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej
patching file LayoutTests/platform/mac/plugins/iframe-plugin-bgcolor-expected.txt
patching file LayoutTests/plugins/iframe-plugin-bgcolor.html
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/html/PluginDocument.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10027059

[Nico Weber]

Created attachment 110416 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 110416 [details]
Patch for landing

Rejecting attachment 110416 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Hunk #1 FAILED at 3758.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej
patching file LayoutTests/platform/mac/plugins/iframe-plugin-bgcolor-expected.txt
patching file LayoutTests/plugins/iframe-plugin-bgcolor.html
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/html/PluginDocument.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10030034

[Nico Weber]

Created attachment 110419 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 110419 [details]
Patch for landing

Clearing flags on attachment: 110419

Committed r97103: <http://trac.webkit.org/changeset/97103>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.