Bug 69693 – [File API] URL methods handling null arguments

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

According to http://dev.w3.org/2006/webapi/FileAPI/#dfn-createObjectURL , "If this method is called with a Blob argument that is NOT valid, then user agents MUST return null." This test calls createObjectURL with null and logs the results.

Expected behavior: returns null
Actual behavior: returns undefined

[Mark Pilgrim (Google)]

Created attachment 110254 [details]
Patch

[Lauro Moura Maranhao Neto]

Created attachment 126983 [details]
Updates test and changes the return value from undefined to null according to the latest spec.

[WebKit Review Bot]

Attachment 126983 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
Using index info to reconstruct a base tree...
<stdin>:1578: trailing whitespace.
        
<stdin>:1647: trailing whitespace.
    
<stdin>:1657: trailing whitespace.
    
<stdin>:1672: trailing whitespace.
        return 0;        
<stdin>:1674: trailing whitespace.
    
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
Falling back to patching base and 3-way merge...
warning: too many files (created: 168776 deleted: 3), skipping inexact rename detection
Auto-merging LayoutTests/ChangeLog
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Auto-merging Source/WebKit2/ChangeLog
CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog
Auto-merging Tools/ChangeLog
CONFLICT (content): Merge conflict in Tools/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Lauro Moura Maranhao Neto]

Created attachment 142001 [details]
Updated patch

[Adam Barth]

Comment on attachment 142001 [details]
Updated patch

Thanks.

[WebKit Review Bot]

Comment on attachment 142001 [details]
Updated patch

Clearing flags on attachment: 142001

Committed r117160: <http://trac.webkit.org/changeset/117160>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.