Bug 69692 - [File API] URL methods required arguments
Summary: [File API] URL methods required arguments
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-07 21:19 PDT by Mark Pilgrim (Google)
Modified: 2011-10-17 10:25 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2011-10-07 21:20 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-10-07 21:19:59 PDT
According to http://dev.w3.org/2006/webapi/FileAPI/#creating-revoking , the URL object has two methods, each of which as a required parameter:

createObjectURL(blob)
revokeObjectURL(url)

This test calls those methods without the required parameter, and logs the results.

WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-10-07 21:20:54 PDT
Created attachment 110252 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-15 00:02:50 PDT
Comment on attachment 110252 [details]
Patch

Clearing flags on attachment: 110252

Committed r97544: <http://trac.webkit.org/changeset/97544>
Comment 3 WebKit Review Bot 2011-10-15 00:02:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2011-10-16 14:30:53 PDT
This test fails on Qt and on SL bot:

--- /Volumes/Big/slave/snowleopard-intel-debug-tests/build/layout-test-results/fast/files/url-required-arguments-expected.txt 
+++ /Volumes/Big/slave/snowleopard-intel-debug-tests/build/layout-test-results/fast/files/url-required-arguments-actual.txt 
@@ -2,7 +2,7 @@
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
-PASS webkitURL.createObjectURL() threw exception TypeError: Type error.
+PASS webkitURL.createObjectURL() threw exception TypeError: Not enough arguments.
 PASS webkitURL.revokeObjectURL() threw exception TypeError: Not enough arguments.
 PASS successfullyParsed is true

Is it a JSC vs. V8 difference problem? As far as I remember in this case JSC result should be the platform independent result and the V8 result should platform specific. Reopen to fix expected results.
Comment 5 Adam Barth 2011-10-16 14:34:14 PDT
-PASS webkitURL.createObjectURL() threw exception TypeError: Type error.
+PASS webkitURL.createObjectURL() threw exception TypeError: Not enough arguments.

Not enough arguments is the correct text of the exception.  We should change V8 to match JSC.

@Mark: Would you like to take care of this, or should I?
Comment 6 Csaba Osztrogonác 2011-10-16 14:38:01 PDT
I added a Qt specific expected file to make the buildbot green. 
Please remove it with the proper fix. Thanks in advance.
Comment 7 Ryosuke Niwa 2011-10-17 10:25:14 PDT
Moved JSC results to cross-platform dir. and then moved V8 specific results to platform/chromium.
http://trac.webkit.org/changeset/97632