Bug 69677 – De-virtualize JSCell::toString

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

Now that the JSC C API does something more sensible for toString (see bug 69156), we can eliminate JSCallbackObject::toString in favor of simply using JSObject::toString to cover the case for JSCallbackObject.

[Mark Hahnenberg]

Created attachment 110398 [details]
Patch

[Darin Adler]

Comment on attachment 110398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110398&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        Removed toString from JSCallbackObject, since it is no 
> +        longer necessary.

Why is it no longer necessary? Because conversion to string is handled in defaultValue? Some other reason?

> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:50
> +    return JSValue(std::numeric_limits<double>::quiet_NaN());

Should not need "std::" here since it’s in a cpp file and we normally use “using namespace std” in those.

> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:75
> +    return JSValue(std::numeric_limits<double>::quiet_NaN());

Ditto.

> Source/JavaScriptGlue/ChangeLog:8
> +        Removed UserObjectImp::toString since it's no longer necessary.

Again, why is it no longer necessary?

[Mark Hahnenberg]

Created attachment 110453 [details]
Fix windows

[Mark Hahnenberg]

Created attachment 110541 [details]
Fix windows

[WebKit Review Bot]

Comment on attachment 110541 [details]
Fix windows

Clearing flags on attachment: 110541

Committed r97292: <http://trac.webkit.org/changeset/97292>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.