Bug 69643 - [FileSystem API] DirectoryEntry.getDirectory path argument is required
Summary: [FileSystem API] DirectoryEntry.getDirectory path argument is required
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-07 11:01 PDT by Mark Pilgrim (Google)
Modified: 2011-12-01 15:15 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.55 KB, patch)
2011-10-07 11:02 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (5.74 KB, patch)
2011-12-01 11:33 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-10-07 11:01:59 PDT
According to http://dev.w3.org/2009/dap/file-system/pub/FileSystem/#idl-def-DirectoryEntry , the first parameter (path) to the getDirectory() method is required. This test calls the method without the required parameter and logs the result.

Expected behavior: throws TypeError: not enough arguments
Actual behavior: no exception thrown
Comment 1 Mark Pilgrim (Google) 2011-10-07 11:02:35 PDT
Created attachment 110177 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2011-12-01 11:33:26 PST
Created attachment 117450 [details]
Patch
Comment 3 Adam Barth 2011-12-01 11:52:26 PST
Comment on attachment 117450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117450&action=review

> LayoutTests/fast/filesystem/resources/simple-required-arguments-getdirectory.js:4
> +if (this.importScripts) {
> +    importScripts('../resources/fs-worker-common.js');
> +    importScripts('../resources/fs-test-util.js');
> +}

Are we actually running this test in a worker?
Comment 4 WebKit Review Bot 2011-12-01 15:14:59 PST
Comment on attachment 117450 [details]
Patch

Clearing flags on attachment: 117450

Committed r101717: <http://trac.webkit.org/changeset/101717>
Comment 5 WebKit Review Bot 2011-12-01 15:15:07 PST
All reviewed patches have been landed.  Closing bug.