Bug 69642 - [FileSystem API] DirectoryEntry.getFile path argument is required
Summary: [FileSystem API] DirectoryEntry.getFile path argument is required
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
Depends on:
Reported: 2011-10-07 10:52 PDT by Mark Pilgrim (Google)
Modified: 2011-11-30 21:44 PST (History)
5 users (show)

See Also:

Patch (2.50 KB, patch)
2011-10-07 10:53 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (5.62 KB, patch)
2011-11-30 13:58 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-10-07 10:52:20 PDT
According to http://dev.w3.org/2009/dap/file-system/pub/FileSystem/#idl-def-DirectoryEntry , the first parameter (path) to the getFile() method is required. This test calls the method without the required parameter and logs the result.

Expected behavior: throws TypeError: not enough arguments
Actual behavior: no exception thrown
Comment 1 Mark Pilgrim (Google) 2011-10-07 10:53:15 PDT
Created attachment 110175 [details]
Comment 2 WebKit Review Bot 2011-10-07 13:29:38 PDT
Comment on attachment 110175 [details]

Attachment 110175 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10007290

New failing tests:
Comment 3 Mark Pilgrim (Google) 2011-10-07 13:35:21 PDT
I assume that's flake; this adds no code, only tests.
Comment 4 Adam Barth 2011-10-07 15:01:58 PDT
Comment on attachment 110175 [details]

Mark, did you mean to include the -expected.txt file and/or nominate the patch for review?  (Also you might want to mark these bugs as blocking the meta Bug 65787 )
Comment 5 Mark Pilgrim (Google) 2011-11-30 13:58:33 PST
Created attachment 117270 [details]
Comment 6 WebKit Review Bot 2011-11-30 21:44:45 PST
Comment on attachment 117270 [details]

Clearing flags on attachment: 117270

Committed r101606: <http://trac.webkit.org/changeset/101606>
Comment 7 WebKit Review Bot 2011-11-30 21:44:50 PST
All reviewed patches have been landed.  Closing bug.