Bug 69638 – [FileSystem API] Entry.getMetadata successCallback is required

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

According to http://dev.w3.org/2009/dap/file-system/pub/FileSystem/#idl-def-Entry , the first parameter (successCallback) of the Entry.getMetadata method is required. This test calls the method without the required argument and logs the result.

Expected behavior: TypeError: not enough arguments
Actual behavior: no exception thrown

[Mark Pilgrim (Google)]

Created attachment 110168 [details]
Patch

[Mark Pilgrim (Google)]

Created attachment 118280 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 118280 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 118280 [details]
Patch

Rejecting attachment 118280 [details] from commit-queue.

New failing tests:
compositing/iframes/scrolling-iframe.html
http/tests/inspector/resource-tree/resource-tree-document-url.html
compositing/iframes/iframe-resize.html
Full output: http://queues.webkit.org/results/10981093

[WebKit Review Bot]

Comment on attachment 118280 [details]
Patch

Rejecting attachment 118280 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
on 374 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium
Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 106.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2210.

Full output: http://queues.webkit.org/results/10997264

[WebKit Review Bot]

Comment on attachment 118280 [details]
Patch

Clearing flags on attachment: 118280

Committed r103501: <http://trac.webkit.org/changeset/103501>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.