Bug 69636 - Just use malloc/free when ADDRESS_SANITIZER is defined in RenderArena
Summary: Just use malloc/free when ADDRESS_SANITIZER is defined in RenderArena
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Abhishek Arya
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-07 09:27 PDT by Martin Barbella
Modified: 2011-10-08 07:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch for address sanitizer in RenderArena (861 bytes, patch)
2011-10-07 09:27 PDT, Martin Barbella 		no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2011-10-07 09:53 PDT, Abhishek Arya 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Barbella 2011-10-07 09:27:08 PDT 
Created attachment 110158 [details]
Patch for address sanitizer in RenderArena

A patch is included to use malloc and free without adding debug headers when ADDRESS_SANITIZER is defined in RenderArena.cpp. The address sanitizer would not be able to detect errors if reads or writes took place in the debug header.

I'm working with Abhishek on cluster fuzz. Adam, could you please review it?
Comment 1 Abhishek Arya 2011-10-07 09:53:36 PDT 
Created attachment 110161 [details]
Patch
Comment 2 Darin Adler 2011-10-07 17:16:41 PDT 
Comment on attachment 110161 [details]
Patch

OK
Comment 3 Abhishek Arya 2011-10-08 06:13:32 PDT 
Comment on attachment 110161 [details]
Patch

Thanks a lot Darin.
Comment 4 WebKit Review Bot 2011-10-08 07:18:43 PDT 
Comment on attachment 110161 [details]
Patch

Clearing flags on attachment: 110161

Committed r97009: <http://trac.webkit.org/changeset/97009>
Comment 5 WebKit Review Bot 2011-10-08 07:18:48 PDT 
All reviewed patches have been landed.  Closing bug.