Bug 69621 - Remove some static functions of HTMLSelectElement
Summary: Remove some static functions of HTMLSelectElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 69518
Blocks: 69701
  Show dependency tree / graph
 
Reported: 2011-10-07 06:29 PDT by Kent Tamura
Modified: 2011-10-08 07:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (18.11 KB, patch)
2011-10-07 06:37 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-10-07 06:29:06 PDT 
Remove some static functions of HTMLSelectElement
Comment 1 Kent Tamura 2011-10-07 06:37:28 PDT 
Created attachment 110134 [details]
Patch
Comment 2 Darin Adler 2011-10-07 08:20:22 PDT 
Comment on attachment 110134 [details]
Patch

Another important refactoring here is to eliminate the SelectElement and OptionElement classes entirely. I was working on that yesterday (bad timing, I guess) but might not get back to it, though.
Comment 3 Ryosuke Niwa 2011-10-07 10:03:01 PDT 
(In reply to comment #2)
> (From update of attachment 110134 [details])
> Another important refactoring here is to eliminate the SelectElement and OptionElement classes entirely. I was working on that yesterday (bad timing, I guess) but might not get back to it, though.

SelectElement has been removed in http://trac.webkit.org/changeset/96907. So I guess we just need to get rid of OptionElement now.
Comment 4 WebKit Review Bot 2011-10-08 02:04:25 PDT 
Comment on attachment 110134 [details]
Patch

Clearing flags on attachment: 110134

Committed r97007: <http://trac.webkit.org/changeset/97007>
Comment 5 WebKit Review Bot 2011-10-08 02:04:30 PDT 
All reviewed patches have been landed.  Closing bug.