Bug 69592 - Pass "accept" mime type information into FileChooser at all call sites
Summary: Pass "accept" mime type information into FileChooser at all call sites
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 18:48 PDT by Joseph Pecoraro
Modified: 2011-10-06 19:54 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Pass accept attribute information to ports via FileChooser (1.31 KB, patch)
2011-10-06 18:51 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-10-06 18:48:01 PDT 
From discussion on:
<http://webkit.org/b/63039> FileChooser should be only created when we need to choose files.

> > Is there a particular reason that this FileChooser doesn't set the acceptTypes?
> > It looks like the accept="..." mime type filter would get ignored in this case,
> > but it is respected with the click/runOpenPanel case.
> 
> There is no reason. We had better pass acceptTypes.
> Chromium's enumeratChosenDirectory() implementaion doesn't have the acceptTypes parameter
> for now. So adding acceptTypes here is harmless.

So this covers adding it!

Patch to follow.
Comment 1 Joseph Pecoraro 2011-10-06 18:51:16 PDT 
Created attachment 110075 [details]
[PATCH] Pass accept attribute information to ports via FileChooser

Added.
Comment 2 Kent Tamura 2011-10-06 18:53:24 PDT 
Comment on attachment 110075 [details]
[PATCH] Pass accept attribute information to ports via FileChooser

OK
Comment 3 WebKit Review Bot 2011-10-06 19:54:47 PDT 
Comment on attachment 110075 [details]
[PATCH] Pass accept attribute information to ports via FileChooser

Clearing flags on attachment: 110075

Committed r96895: <http://trac.webkit.org/changeset/96895>
Comment 4 WebKit Review Bot 2011-10-06 19:54:51 PDT 
All reviewed patches have been landed.  Closing bug.