Bug 69588 – AX: re-organize fake elements to use new AccessibilityMockObject

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

This AccessibilityMockObject will consolidate the ways that these fake elements store and retrieve their parent objects.

[chris fleizach]

Created attachment 110072 [details]
patch

[Gyuyoung Kim]

Comment on attachment 110072 [details]
patch

Attachment 110072 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10010039

[WebKit Review Bot]

Comment on attachment 110072 [details]
patch

Attachment 110072 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10010064

[Collabora GTK+ EWS bot]

Comment on attachment 110072 [details]
patch

Attachment 110072 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10006102

[Jon Honeycutt]

Comment on attachment 110072 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110072&action=review

Please fix the build issues before committing. r=me

> Source/WebCore/accessibility/AccessibilityMockObject.h:15
> + * 1.  Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in the
> + *     documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission.

This has a different version of the license than AccessibilityMockObject.cpp. We use the two clause version in new code.

> Source/WebCore/accessibility/AccessibilityMockObject.h:41
> +    static PassRefPtr<AccessibilityMockObject> create();

I think you can remove this. I don't see it used or defined.

[chris fleizach]

Created attachment 110159 [details]
patch to verify building

[chris fleizach]

http://trac.webkit.org/changeset/96966