Bug 69588 - AX: re-organize fake elements to use new AccessibilityMockObject
Summary: AX: re-organize fake elements to use new AccessibilityMockObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks: 69562
  Show dependency treegraph
 
Reported: 2011-10-06 18:17 PDT by chris fleizach
Modified: 2011-10-07 12:12 PDT (History)
5 users (show)

See Also:


Attachments
patch (34.89 KB, patch)
2011-10-06 18:24 PDT, chris fleizach
jhoneycutt: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
patch to verify building (37.75 KB, patch)
2011-10-07 09:31 PDT, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2011-10-06 18:17:01 PDT
This AccessibilityMockObject will consolidate the ways that these fake elements store and retrieve their parent objects.
Comment 1 chris fleizach 2011-10-06 18:24:46 PDT
Created attachment 110072 [details]
patch
Comment 2 Gyuyoung Kim 2011-10-06 18:43:43 PDT
Comment on attachment 110072 [details]
patch

Attachment 110072 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10010039
Comment 3 WebKit Review Bot 2011-10-06 20:15:49 PDT
Comment on attachment 110072 [details]
patch

Attachment 110072 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10010064
Comment 4 Collabora GTK+ EWS bot 2011-10-06 22:17:52 PDT
Comment on attachment 110072 [details]
patch

Attachment 110072 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10006102
Comment 5 Jon Honeycutt 2011-10-07 02:20:15 PDT
Comment on attachment 110072 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110072&action=review

Please fix the build issues before committing. r=me

> Source/WebCore/accessibility/AccessibilityMockObject.h:15
> + * 1.  Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in the
> + *     documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission.

This has a different version of the license than AccessibilityMockObject.cpp. We use the two clause version in new code.

> Source/WebCore/accessibility/AccessibilityMockObject.h:41
> +    static PassRefPtr<AccessibilityMockObject> create();

I think you can remove this. I don't see it used or defined.
Comment 6 chris fleizach 2011-10-07 09:31:42 PDT
Created attachment 110159 [details]
patch to verify building
Comment 7 chris fleizach 2011-10-07 12:12:09 PDT
http://trac.webkit.org/changeset/96966