Bug 69587 - REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
Summary: REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 17:23 PDT by Ryosuke Niwa
Modified: 2011-10-10 16:08 PDT (History)
7 users (show)

See Also:

Attachments
fixes the bug (3.19 KB, patch)
2011-10-07 16:13 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Added the forgotten change log entry for LayoutTests (3.82 KB, patch)
2011-10-07 16:15 PDT, Ryosuke Niwa 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
one more rebaseline (3.19 KB, patch)
2011-10-07 21:54 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
one more correction (12.18 KB, patch)
2011-10-07 22:17 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-10-06 17:23:37 PDT 
It seems like my patch regressed one test on non-Mac platforms.
Comment 2 Ryosuke Niwa 2011-10-07 16:13:21 PDT 
Created attachment 110229 [details]
fixes the bug

I'll remove entries from other platforms one this patch is landed.
Comment 3 Ryosuke Niwa 2011-10-07 16:15:19 PDT 
Created attachment 110230 [details]
Added the forgotten change log entry for LayoutTests
Comment 4 WebKit Review Bot 2011-10-07 17:17:29 PDT 
Comment on attachment 110230 [details]
Added the forgotten change log entry for LayoutTests

Attachment 110230 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10000377

New failing tests:
fast/events/ondragenter.html
Comment 5 Ryosuke Niwa 2011-10-07 21:54:46 PDT 
Created attachment 110255 [details]
one more rebaseline
Comment 6 Ryosuke Niwa 2011-10-07 22:17:32 PDT 
Created attachment 110257 [details]
one more correction
Comment 7 WebKit Review Bot 2011-10-07 22:57:53 PDT 
Comment on attachment 110257 [details]
one more correction

Attachment 110257 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10006396

New failing tests:
fast/events/ondragenter.html
Comment 8 Enrica Casucci 2011-10-10 14:53:39 PDT 
Comment on attachment 110257 [details]
one more correction

Looks good to me.
Comment 9 Ryosuke Niwa 2011-10-10 14:57:09 PDT 
Comment on attachment 110257 [details]
one more correction

Thanks for the review!
Comment 10 Ryosuke Niwa 2011-10-10 16:08:08 PDT 
Comment on attachment 110257 [details]
one more correction

Clearing flags on attachment: 110257

Committed r97102: <http://trac.webkit.org/changeset/97102>
Comment 11 Ryosuke Niwa 2011-10-10 16:08:12 PDT 
All reviewed patches have been landed.  Closing bug.