Bug 69584 – Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds

[Anders Carlsson]

Created attachment 110063 [details]
Patch

[Darin Adler]

Comment on attachment 110063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110063&action=review

> Source/JavaScriptCore/wtf/StdLibExtras.h:48
> +// non-trivial constructor and destructor. When building with clang, this will supress
> +// warnings about global constructors and exit-time destructors.

How does it suppress those warnings?

Typo: suppress

[WebKit Review Bot]

Attachment 110063 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/dom/Node.cpp:288:  Extra space before )  [whitespace/parens] [2]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 110063 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110063&action=review
> 
> > Source/JavaScriptCore/wtf/StdLibExtras.h:48
> > +// non-trivial constructor and destructor. When building with clang, this will supress
> > +// warnings about global constructors and exit-time destructors.
> 
> How does it suppress those warnings?
> 

I'll add that in an upcoming patch - I removed the last sentence for now.

[Anders Carlsson]

Committed r96880: <http://trac.webkit.org/changeset/96880>