Bug 69584 - Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
Summary: Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 17:07 PDT by Anders Carlsson
Modified: 2011-10-06 17:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (15.54 KB, patch)
2011-10-06 17:12 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-10-06 17:07:24 PDT 
Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
Comment 1 Anders Carlsson 2011-10-06 17:12:44 PDT 
Created attachment 110063 [details]
Patch
Comment 2 Darin Adler 2011-10-06 17:15:55 PDT 
Comment on attachment 110063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110063&action=review

> Source/JavaScriptCore/wtf/StdLibExtras.h:48
> +// non-trivial constructor and destructor. When building with clang, this will supress
> +// warnings about global constructors and exit-time destructors.

How does it suppress those warnings?

Typo: suppress
Comment 3 WebKit Review Bot 2011-10-06 17:16:08 PDT 
Attachment 110063 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/dom/Node.cpp:288:  Extra space before )  [whitespace/parens] [2]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2011-10-06 17:18:50 PDT 
(In reply to comment #2)
> (From update of attachment 110063 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110063&action=review
> 
> > Source/JavaScriptCore/wtf/StdLibExtras.h:48
> > +// non-trivial constructor and destructor. When building with clang, this will supress
> > +// warnings about global constructors and exit-time destructors.
> 
> How does it suppress those warnings?
> 

I'll add that in an upcoming patch - I removed the last sentence for now.
Comment 5 Anders Carlsson 2011-10-06 17:19:21 PDT 
Committed r96880: <http://trac.webkit.org/changeset/96880>