Bug 69575 – Extract WebOpenPanelResultListener out into its own file

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Joseph Pecoraro]

Extract WebOpenPanelResultListener out into its own file.

[Joseph Pecoraro]

Created attachment 110061 [details]
[PATCH] Extract WebOpenPanelListener into its own file

• Copyright (C) 2008 Apple Inc. since that is when the code was added and it hasn't really changed since.
• I added some missing forward declarations to WebUIDelegate.h. That is a Public API header. Does this need special consideration?

[Joseph Pecoraro]

Extracting the code from WebView.mm I was able to combine an ENABLE(FULLSCREEN)
block above it and below it. In case you were wondering what those were.

[WebKit Review Bot]

Attachment 110061 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1

Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:34:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Kilzer (:ddkilzer)]

Comment on attachment 110061 [details]
[PATCH] Extract WebOpenPanelListener into its own file

View in context: https://bugs.webkit.org/attachment.cgi?id=110061&action=review

>> Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:30
>> +    class FileChooser;
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

This one should be fixed.

>> Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:34
>> +{
> 
> This { should be at the end of the previous line  [whitespace/braces] [4]

I think this one can be ignored.

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> • I added some missing forward declarations to WebUIDelegate.h. That is a Public API header. Does this need special consideration?

Nope.  Those are public classes, so I don't see any problem with adding @class declarations for them.

[Joseph Pecoraro]

> >> Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:30
> >> +    class FileChooser;
> > 
> > Code inside a namespace should not be indented.  [whitespace/indent] [4]
> 
> This one should be fixed.

Done.

[Joseph Pecoraro]

Landed in r97095 <http://trac.webkit.org/changeset/97095>.