Bug 69561 - [GTK] Don't expose objects with unknown role on GTK
Summary: [GTK] Don't expose objects with unknown role on GTK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mario Sanchez Prada
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-10-06 13:53 PDT by Mario Sanchez Prada
Modified: 2011-10-07 02:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.77 KB, patch)
2011-10-06 14:06 PDT, Mario Sanchez Prada 		cfleizach: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2011-10-06 13:53:19 PDT 
WebKitGTK is currently exposing objects with role unknown, which is wrong and, besides this, is preventing us to enable the new a11y layout test accessibility/deleting-iframe-destroys-axcache.html by providing a new expectations file.

Of course, when it comes to enabling that new test we could of course generate the expected file now, but then one of the assertions would failing due to this bug, since this is how the a11y hierarchy for test looks right now:

 AXRole: scroll pane 
     AXRole: document frame 
         AXRole: paragraph 
         AXRole: panel 
             AXRole: unknown 
                 AXRole: scroll pane 
                     AXRole: document frame 
                         AXRole: panel 
                             AXRole: push button 

...and this is how it should look:

 AXRole: scroll pane 
     AXRole: document frame 
         AXRole: paragraph 
         AXRole: panel 
             AXRole: scroll pane 
                 AXRole: document frame 
                     AXRole: panel 
                         AXRole: push button
Comment 1 Mario Sanchez Prada 2011-10-06 14:06:05 PDT 
Created attachment 110015 [details]
Patch
Comment 2 Mario Sanchez Prada 2011-10-06 14:10:21 PDT 
Adding Chris to CC, as this patch basically mimics something they are already doing on the Mac.
Comment 3 chris fleizach 2011-10-06 14:13:22 PDT 
Comment on attachment 110015 [details]
Patch

r=me
Comment 4 Mario Sanchez Prada 2011-10-07 02:51:00 PDT 
Committed r96922: <http://trac.webkit.org/changeset/96922>