Bug 69538 - InlineBox's virtualLogicalHeight() partially limited to builds with SVG.
Summary: InlineBox's virtualLogicalHeight() partially limited to builds with SVG.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 10:27 PDT by Andreas Kling
Modified: 2011-10-06 10:52 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (2.29 KB, patch)
2011-10-06 10:30 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-06 10:27:13 PDT 
The InlineBox::m_hasVirtualLogicalHeight flag is only initialized by the constructor if built with ENABLE(SVG), and furthermore InlineBox::logicalHeight() only checks it if built with ENABLE(SVG).
Since this mechanism is used by TrailingFloatsRootInlineBox, it shouldn't be limited to SVG builds.
Comment 1 Andreas Kling 2011-10-06 10:30:46 PDT 
Created attachment 109974 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-10-06 10:52:24 PDT 
Comment on attachment 109974 [details]
Proposed patch

Clearing flags on attachment: 109974

Committed r96832: <http://trac.webkit.org/changeset/96832>
Comment 3 WebKit Review Bot 2011-10-06 10:52:30 PDT 
All reviewed patches have been landed.  Closing bug.