Bug 69537 - conditionalize m_cachedScript stacks to just Chromium port
Summary: conditionalize m_cachedScript stacks to just Chromium port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Peters
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 10:24 PDT by Gavin Peters
Modified: 2011-10-06 12:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.97 KB, patch)
2011-10-06 10:27 PDT, Gavin Peters 		japhet: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2011-10-06 10:24:59 PDT 
conditionalize m_cachedScript stacks to just Chromium port
Comment 1 Gavin Peters 2011-10-06 10:27:11 PDT 
Created attachment 109973 [details]
Patch
Comment 2 Gavin Peters 2011-10-06 10:28:11 PDT 
This should save non chromium ports from paying the price for this diagnostics.
Comment 3 Gavin Peters 2011-10-06 10:29:13 PDT 
Comment on attachment 109973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109973&action=review

We should wait on bots for this, as #ifdefs are scary.

> Source/WebCore/dom/ScriptElement.h:115
> +        ZeroedInNotifyFinished,

This bad indent was bugging me, so I also fixed it here.
Comment 4 Gavin Peters 2011-10-06 12:30:22 PDT 
Committed r96849: <http://trac.webkit.org/changeset/96849>