Bug 69533 - [EFL] Do not create cairo surfaces with the wrong size for form elements
: [EFL] Do not create cairo surfaces with the wrong size for form elements
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit EFL
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Raphael Kubo da Costa (:rakuco)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-06 09:41 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-10-06 12:15 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2011-10-06 09:43 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-10-06 09:41:18 PDT
[EFL] Do not create cairo surfaces with the wrong size for form elements
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-10-06 09:43:54 PDT
Created attachment 109969 [details]
Patch
Comment 2 Ryosuke Niwa 2011-10-06 10:26:27 PDT
Any informal reviews from EFL contributors?
Comment 3 Leandro Pereira 2011-10-06 10:47:25 PDT
Comment on attachment 109969 [details]
Patch

Informal r+.
Comment 4 Ryosuke Niwa 2011-10-06 10:50:39 PDT
Comment on attachment 109969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109969&action=review

> Source/WebCore/ChangeLog:21
> +        No new tests, this is triggered by running running pixel tests for
> +        running, in this order, fast/forms/button-sizes.html,
> +        fast/forms/input-appearance-preventDefault.html,
> +        fast/forms/input-appearance-spinbutton-disabled-readonly.html,
> +        fast/forms/input-appearance-width.html,
> +        fast/forms/input-button-sizes.html,
> +        fast/forms/input-placeholder-text-indent.html and
> +        fast/forms/input-text-click-inside.html (!).

Should this patch cause a rebaseline? Don't we need to rebaseline these tests for EFL?
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-10-06 10:59:33 PDT
(In reply to comment #4)
> (From update of attachment 109969 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109969&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +        No new tests, this is triggered by running running pixel tests for
> > +        running, in this order, fast/forms/button-sizes.html,
> > +        fast/forms/input-appearance-preventDefault.html,
> > +        fast/forms/input-appearance-spinbutton-disabled-readonly.html,
> > +        fast/forms/input-appearance-width.html,
> > +        fast/forms/input-button-sizes.html,
> > +        fast/forms/input-placeholder-text-indent.html and
> > +        fast/forms/input-text-click-inside.html (!).
> 
> Should this patch cause a rebaseline? Don't we need to rebaseline these tests for EFL?

We haven't finished upstreaming our DRT code yet, so we still don't have any baselines upstream.
Comment 6 Ryosuke Niwa 2011-10-06 11:01:06 PDT
Comment on attachment 109969 [details]
Patch

Okay. Sane enough to me.
Comment 7 WebKit Review Bot 2011-10-06 12:15:03 PDT
Comment on attachment 109969 [details]
Patch

Clearing flags on attachment: 109969

Committed r96844: <http://trac.webkit.org/changeset/96844>
Comment 8 WebKit Review Bot 2011-10-06 12:15:07 PDT
All reviewed patches have been landed.  Closing bug.