Bug 69533 - [EFL] Do not create cairo surfaces with the wrong size for form elements
: [EFL] Do not create cairo surfaces with the wrong size for form elements
Status: RESOLVED FIXED
: WebKit
WebKit EFL
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-10-06 09:41 PST by
Modified: 2011-10-06 12:15 PST (History)


Attachments
Patch (2.39 KB, patch)
2011-10-06 09:43 PST, Raphael Kubo da Costa (:rakuco)
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-10-06 09:41:18 PST
[EFL] Do not create cairo surfaces with the wrong size for form elements
------- Comment #1 From 2011-10-06 09:43:54 PST -------
Created an attachment (id=109969) [details]
Patch
------- Comment #2 From 2011-10-06 10:26:27 PST -------
Any informal reviews from EFL contributors?
------- Comment #3 From 2011-10-06 10:47:25 PST -------
(From update of attachment 109969 [details])
Informal r+.
------- Comment #4 From 2011-10-06 10:50:39 PST -------
(From update of attachment 109969 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=109969&action=review

> Source/WebCore/ChangeLog:21
> +        No new tests, this is triggered by running running pixel tests for
> +        running, in this order, fast/forms/button-sizes.html,
> +        fast/forms/input-appearance-preventDefault.html,
> +        fast/forms/input-appearance-spinbutton-disabled-readonly.html,
> +        fast/forms/input-appearance-width.html,
> +        fast/forms/input-button-sizes.html,
> +        fast/forms/input-placeholder-text-indent.html and
> +        fast/forms/input-text-click-inside.html (!).

Should this patch cause a rebaseline? Don't we need to rebaseline these tests for EFL?
------- Comment #5 From 2011-10-06 10:59:33 PST -------
(In reply to comment #4)
> (From update of attachment 109969 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109969&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +        No new tests, this is triggered by running running pixel tests for
> > +        running, in this order, fast/forms/button-sizes.html,
> > +        fast/forms/input-appearance-preventDefault.html,
> > +        fast/forms/input-appearance-spinbutton-disabled-readonly.html,
> > +        fast/forms/input-appearance-width.html,
> > +        fast/forms/input-button-sizes.html,
> > +        fast/forms/input-placeholder-text-indent.html and
> > +        fast/forms/input-text-click-inside.html (!).
> 
> Should this patch cause a rebaseline? Don't we need to rebaseline these tests for EFL?

We haven't finished upstreaming our DRT code yet, so we still don't have any baselines upstream.
------- Comment #6 From 2011-10-06 11:01:06 PST -------
(From update of attachment 109969 [details])
Okay. Sane enough to me.
------- Comment #7 From 2011-10-06 12:15:03 PST -------
(From update of attachment 109969 [details])
Clearing flags on attachment: 109969

Committed r96844: <http://trac.webkit.org/changeset/96844>
------- Comment #8 From 2011-10-06 12:15:07 PST -------
All reviewed patches have been landed.  Closing bug.