[EFL] Do not create cairo surfaces with the wrong size for form elements
Created attachment 109969 [details] Patch
Any informal reviews from EFL contributors?
Comment on attachment 109969 [details] Patch Informal r+.
Comment on attachment 109969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109969&action=review > Source/WebCore/ChangeLog:21 > + No new tests, this is triggered by running running pixel tests for > + running, in this order, fast/forms/button-sizes.html, > + fast/forms/input-appearance-preventDefault.html, > + fast/forms/input-appearance-spinbutton-disabled-readonly.html, > + fast/forms/input-appearance-width.html, > + fast/forms/input-button-sizes.html, > + fast/forms/input-placeholder-text-indent.html and > + fast/forms/input-text-click-inside.html (!). Should this patch cause a rebaseline? Don't we need to rebaseline these tests for EFL?
(In reply to comment #4) > (From update of attachment 109969 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109969&action=review > > > Source/WebCore/ChangeLog:21 > > + No new tests, this is triggered by running running pixel tests for > > + running, in this order, fast/forms/button-sizes.html, > > + fast/forms/input-appearance-preventDefault.html, > > + fast/forms/input-appearance-spinbutton-disabled-readonly.html, > > + fast/forms/input-appearance-width.html, > > + fast/forms/input-button-sizes.html, > > + fast/forms/input-placeholder-text-indent.html and > > + fast/forms/input-text-click-inside.html (!). > > Should this patch cause a rebaseline? Don't we need to rebaseline these tests for EFL? We haven't finished upstreaming our DRT code yet, so we still don't have any baselines upstream.
Comment on attachment 109969 [details] Patch Okay. Sane enough to me.
Comment on attachment 109969 [details] Patch Clearing flags on attachment: 109969 Committed r96844: <http://trac.webkit.org/changeset/96844>
All reviewed patches have been landed. Closing bug.