Bug 69528 – REGRESSION(r96791): webkit_unit_tests broken on Mac and Win (Requested by hwennborg on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/96791 broke the build:
webkit_unit_tests broken on Mac and Win (Requested by hwennborg on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 109963 [details]
ROLLOUT of r96791

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Hans Wennborg]

Terribly sorry to roll out, but this seems to have broken webkit_unit_tests, at least on Mac and Windows.

Webkit Win (dbg)(1):

[----------] 1 test from CCLayerTreeHostTestShortlived1
[ RUN      ] CCLayerTreeHostTestShortlived1.run
Backtrace:
	WebCore::CCLayerTreeHost::animateAndLayout [0x00A580D2+18] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\platform\graphics\chromium\cc\cclayertreehost.cpp:109)
	WebCore::CCThreadProxy::beginFrameAndCommit [0x00B0556F+255] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\platform\graphics\chromium\cc\ccthreadproxy.cpp:370)
	WebCore::MainThreadTask3<WebCore::CCThreadProxy,int,int,double,double,WTF::PassOwnPtr<WTF::Vector<WebCore::CCLayerTreeHostCommon::ScrollUpdateInfo,0> >,WTF::PassOwnPtr<WTF::Vector<WebCore::CCLayerTreeHostCommon::ScrollUpdateInfo,0> > >::performTask [0x00B07BEB+75] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\platform\graphics\chromium\cc\ccmainthreadtask.h:152)
	WebCore::CCMainThread::performTask [0x00A2891D+45] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\platform\graphics\chromium\cc\ccmainthread.cpp:37)
	DispatchToFunction<void (__cdecl*)(void *),void *> [0x014F78DF+15] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\tuple.h:610)
	RunnableFunction<void (__cdecl*)(void *),Tuple1<void *> >::Run [0x014F757A+42] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\task.h:477)
	base::subtle::TaskClosureAdapter::Run [0x01561A82+50] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\task.cc:71)
	base::internal::Invoker1<0,base::internal::InvokerStorage1<void (__thiscall base::subtle::TaskClosureAdapter::*)(void),base::subtle::TaskClosureAdapter *>,void (__thiscall base::subtle::TaskClosureAdapter::*)(void)>::DoInvoke [0x0155B8AD+45] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\bind_internal.h:596)
	base::Callback<void __cdecl(void)>::Run [0x0150CF0F+47] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\callback.h:269)
	MessageLoop::RunTask [0x01551C73+483] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:483)
	MessageLoop::DeferOrRunPendingTask [0x01551E43+51] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:500)
	MessageLoop::DoWork [0x0155287D+221] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:687)
	base::MessagePumpForUI::DoRunLoop [0x015959E4+84] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_pump_win.cc:203)
	base::MessagePumpWin::RunWithDispatcher [0x01595262+130] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_pump_win.cc:51)
	base::MessagePumpWin::Run [0x015954CC+28] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_pump_win.h:64)
	MessageLoop::RunInternal [0x015518D7+247] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:444)
	MessageLoop::RunHandler [0x015516AE+46] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:418)
	MessageLoop::Run [0x01550FBA+58] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:342)
	webkit_support::RunMessageLoop [0x014F326F+15] (e:\b\build\slave\webkit_win__dbg__1_\build\src\webkit\support\webkit_support.cc:401)
	`anonymous namespace'::CCLayerTreeHostTest::runTest [0x004D7D1D+77] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webkit\chromium\tests\cclayertreehosttest.cpp:257)
	`anonymous namespace'::CCLayerTreeHostTestShortlived1_run_Test::TestBody [0x004D6C9E+30] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webkit\chromium\tests\cclayertreehosttest.cpp:349)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x015F5AB7+55] (e:\b\build\slave\webkit_win__dbg__1_\build\src\testing\gtest\src\gtest.cc:2145)
	testing::Test::Run [0x015E2F3E+174] (e:\b\build\slave\webkit_win__dbg__1_\build\src\testing\gtest\src\gtest.cc:2162)
	testing::TestInfo::Run [0x015E37FD+221] (e:\b\build\slave\webkit_win__dbg__1_\build\src\testing\gtest\src\gtest.cc:2342)
	testing::TestCase::Run [0x015E3EFF+239] (e:\b\build\slave\webkit_win__dbg__1_\build\src\testing\gtest\src\gtest.cc:2446)
	testing::internal::UnitTestImpl::RunAllTests [0x015E9060+640] (e:\b\build\slave\webkit_win__dbg__1_\build\src\testing\gtest\src\gtest.cc:4238)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x015F5F97+55] (e:\b\build\slave\webkit_win__dbg__1_\build\src\testing\gtest\src\gtest.cc:2145)
	testing::UnitTest::Run [0x015E7C7C+172] (e:\b\build\slave\webkit_win__dbg__1_\build\src\testing\gtest\src\gtest.cc:3874)
	base::TestSuite::Run [0x01503951+177] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\test\test_suite.cc:135)
	main [0x004C1173+67] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webkit\chromium\tests\runalltests.cpp:57)
	__tmainCRTStartup [0x016BA617+279] (f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c:266)
	mainCRTStartup [0x016BA4EF+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c:182)
	RegisterWaitForInputIdle [0x7C817077+73]
Backtrace:
	(No symbol) [0x00000000]
	mainCRTStartup [0x016BA4E0+0] (f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c:172)
Backtrace:
	(No symbol) [0x00000000]
	(No symbol) [0x78746341]
Backtrace:
	(No symbol) [0x00000000]
Backtrace:
	(No symbol) [0x00000000]


Webkit Mac10.5

[----------] 1 test from CCLayerTreeHostTestShortlived1
[ RUN      ] CCLayerTreeHostTestShortlived1.run
[58341:267:1006/062231:925530757009957:ERROR:process_util_posix.cc(134)] Received signal 10
	0   webkit_unit_tests                   0x77ebbd41 _mh_execute_header + 1908033
	1   webkit_unit_tests                   0x77ee19ab _mh_execute_header + 2062763
	2   libSystem.B.dylib                   0x91c921cb _sigtramp + 43
	3   ???                                 0xffffffff 0x0 + 4294967295
	4   webkit_unit_tests                   0x78bebc67 _mh_execute_header + 15735911
	5   webkit_unit_tests                   0x78bec7ac _mh_execute_header + 15738796
	6   webkit_unit_tests                   0x78be8bd2 _mh_execute_header + 15723474
	7   webkit_unit_tests                   0x77eef625 _mh_execute_header + 2119205
	8   webkit_unit_tests                   0x77ed0ea8 _mh_execute_header + 1994408
	9   webkit_unit_tests                   0x77ed1aa8 _mh_execute_header + 1997480
	10  webkit_unit_tests                   0x77ead46e _mh_execute_header + 1848430
	11  CoreFoundation                      0x966903c5 CFRunLoopRunSpecific + 3141
	12  CoreFoundation                      0x96690aa8 CFRunLoopRunInMode + 88
	13  HIToolbox                           0x97b5e2ac BlockUntilNextEventMatchingListInMode + 989
	14  HIToolbox                           0x97b5e0c5 BlockUntilNextEventMatchingListInMode + 502
	15  HIToolbox                           0x97b5df39 BlockUntilNextEventMatchingListInMode + 106
	16  AppKit                              0x95a5b6d5 _DPSNextEvent + 657
	17  AppKit                              0x95a5af88 _NSUpdateMenuRefWithChangedMenuItem + 2250
	18  AppKit                              0x95a53f9f _NSSetViewMultiClipDrawingHelper + 4866
	19  webkit_unit_tests                   0x77ead30b _mh_execute_header + 1848075
	20  webkit_unit_tests                   0x77eacb20 _mh_execute_header + 1846048
	21  webkit_unit_tests                   0x77ececfd _mh_execute_header + 1985789
	22  webkit_unit_tests                   0x77ecee24 _mh_execute_header + 1986084
	23  webkit_unit_tests                   0x77efd6a3 _mh_execute_header + 2176675
	24  webkit_unit_tests                   0x77d0292b _mh_execute_header + 100651
	25  webkit_unit_tests                   0x77e98f0a _mh_execute_header + 1765130
	26  webkit_unit_tests                   0x77e993ef _mh_execute_header + 1766383
	27  webkit_unit_tests                   0x77e99592 _mh_execute_header + 1766802
	28  webkit_unit_tests                   0x77e9c442 _mh_execute_header + 1778754
	29  webkit_unit_tests                   0x77e92c55 _mh_execute_header + 1739861
	30  webkit_unit_tests                   0x77efa57d _mh_execute_header + 2164093
	31  webkit_unit_tests                   0x77ceb691 _mh_execute_header + 5777
	32  webkit_unit_tests                   0x77ceb606 _mh_execute_header + 5638
	33  ???                                 0x00000002 0x0 + 2
ax: 4, bx: 78bebbe1, cx: 7a2f1568, dx: 797e2f4c
di: 14a430, si: 4, bp: bfffdb98, sp: bfffdb80, ss: 1f, flags: 10282
ip: 78be6a8a, cs: 17, ds: 1f, es: 1f, fs: 0, gs: 37
program finished with exit code 1
elapsedTime=2.162339

[WebKit Review Bot]

Comment on attachment 109963 [details]
ROLLOUT of r96791

Clearing flags on attachment: 109963

Committed r96813: <http://trac.webkit.org/changeset/96813>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[James Robinson]

Sorry about that - it passed on my linux box and I watched it go through the linux waterfall bot (since it's the fastest cycling) and assumed it was all good :/.  Thanks for keeping the bot green!