Bug 69516 - Web Inspector: Inspector fails to start if there was at least one watch expression.
Summary: Web Inspector: Inspector fails to start if there was at least one watch expre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 04:11 PDT by Vsevolod Vlasov
Modified: 2011-10-06 06:03 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2011-10-06 05:41 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-10-06 04:11:43 PDT 
Inspector fails to start if there was at least one watch expression added.

[19960:19960:652471493820:ERROR:CONSOLE(569)] "Uncaught TypeError: Cannot read property 'paused' of undefined", source: chrome-devtools://devtools/ConsoleView.js (569)
Comment 1 Vsevolod Vlasov 2011-10-06 04:13:05 PDT 
Related lines from ConsoleView.js:

    evalInInspectedWindow: function(expression, objectGroup, includeCommandLineAPI, doNotPauseOnExceptions, returnByValue, callback)
    {
        if (WebInspector.panels.scripts.paused) { <-- fails here.
            WebInspector.panels.scripts.evaluateInSelectedCallFrame(expression, objectGroup, includeCommandLineAPI, returnByValue, callback);
            return;
        }
Comment 2 Pavel Feldman 2011-10-06 05:41:58 PDT 
Created attachment 109949 [details]
Patch
Comment 3 Yury Semikhatsky 2011-10-06 05:49:43 PDT 
Comment on attachment 109949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109949&action=review

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:60
>          this._wasShown = true;

Please move this line right after the if (this._wasShown) above.
Comment 4 Pavel Feldman 2011-10-06 06:03:59 PDT 
Committed r96804: <http://trac.webkit.org/changeset/96804>