Bug 69505 - [EFL] Change data type of parameter in ewk_view_viewport_attributes_get()
Summary: [EFL] Change data type of parameter in ewk_view_viewport_attributes_get()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 01:02 PDT by Gyuyoung Kim
Modified: 2011-10-06 19:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2011-10-06 01:05 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-10-06 01:02:06 PDT 
ewk_view_viewport_attributes_get() has used implicit casting for width and height of viewport. However, it is better to use *int* data type as parameter data type instead of *float* casting.
Comment 1 Gyuyoung Kim 2011-10-06 01:05:25 PDT 
Created attachment 109931 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-10-06 06:40:16 PDT 
LGTM.
Comment 3 Andreas Kling 2011-10-06 11:16:28 PDT 
Comment on attachment 109931 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2011-10-06 19:22:11 PDT 
Comment on attachment 109931 [details]
Patch

Clearing flags on attachment: 109931

Committed r96890: <http://trac.webkit.org/changeset/96890>
Comment 5 WebKit Review Bot 2011-10-06 19:22:17 PDT 
All reviewed patches have been landed.  Closing bug.