RESOLVED FIXED69505
[EFL] Change data type of parameter in ewk_view_viewport_attributes_get() 
https://bugs.webkit.org/show_bug.cgi?id=69505
Summary [EFL] Change data type of parameter in ewk_view_viewport_attributes_get()
Gyuyoung Kim
Reported 2011-10-06 01:02:06 PDT
ewk_view_viewport_attributes_get() has used implicit casting for width and height of viewport. However, it is better to use *int* data type as parameter data type instead of *float* casting.
Attachments
Patch (4.92 KB, patch)
2011-10-06 01:05 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-10-06 01:05:25 PDT
Created attachment 109931 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-10-06 06:40:16 PDT
LGTM.
Andreas Kling
Comment 3 2011-10-06 11:16:28 PDT
Comment on attachment 109931 [details] Patch r=me
WebKit Review Bot
Comment 4 2011-10-06 19:22:11 PDT
Comment on attachment 109931 [details] Patch Clearing flags on attachment: 109931 Committed r96890: <http://trac.webkit.org/changeset/96890>
WebKit Review Bot
Comment 5 2011-10-06 19:22:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.