Bug 69492 - [Mac] Should be able to scroll embedded PDFs from keyboard
Summary: [Mac] Should be able to scroll embedded PDFs from keyboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 67774
  Show dependency tree / graph
 
Reported: 2011-10-05 17:43 PDT by Alexey Proskuryakov
Modified: 2011-10-06 10:04 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (13.46 KB, patch)
2011-10-05 18:00 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-10-05 17:43:42 PDT 
Keyboard commands like arrow keys, PgUp/PgDown and Space should scroll a PDF view.
Comment 1 Alexey Proskuryakov 2011-10-05 18:00:19 PDT 
Created attachment 109896 [details]
proposed fix
Comment 2 Darin Adler 2011-10-05 18:02:13 PDT 
Comment on attachment 109896 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=109896&action=review

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:259
> +    PluginViewBase* view = static_cast<PluginViewBase*>(widget());
> +    return view->scroll(direction, granularity);

I don’t think the local variable adds clarity.

> Source/WebCore/rendering/RenderEmbeddedObject.h:71
> +    virtual bool scroll(ScrollDirection, ScrollGranularity, float multiplier = 1, Node** stopNode = 0);
> +    virtual bool logicalScroll(ScrollLogicalDirection, ScrollGranularity, float multiplier = 1, Node** stopNode = 0);

Might not need the default values on these overrides.
Comment 3 Alexey Proskuryakov 2011-10-06 10:04:11 PDT 
Committed <http://trac.webkit.org/changeset/96823>.