RESOLVED FIXED 69492
[Mac] Should be able to scroll embedded PDFs from keyboard
https://bugs.webkit.org/show_bug.cgi?id=69492
Summary [Mac] Should be able to scroll embedded PDFs from keyboard
Alexey Proskuryakov
Reported 2011-10-05 17:43:42 PDT
Keyboard commands like arrow keys, PgUp/PgDown and Space should scroll a PDF view.
Attachments
proposed fix (13.46 KB, patch)
2011-10-05 18:00 PDT, Alexey Proskuryakov
darin: review+
Alexey Proskuryakov
Comment 1 2011-10-05 18:00:19 PDT
Created attachment 109896 [details] proposed fix
Darin Adler
Comment 2 2011-10-05 18:02:13 PDT
Comment on attachment 109896 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=109896&action=review > Source/WebCore/rendering/RenderEmbeddedObject.cpp:259 > + PluginViewBase* view = static_cast<PluginViewBase*>(widget()); > + return view->scroll(direction, granularity); I don’t think the local variable adds clarity. > Source/WebCore/rendering/RenderEmbeddedObject.h:71 > + virtual bool scroll(ScrollDirection, ScrollGranularity, float multiplier = 1, Node** stopNode = 0); > + virtual bool logicalScroll(ScrollLogicalDirection, ScrollGranularity, float multiplier = 1, Node** stopNode = 0); Might not need the default values on these overrides.
Alexey Proskuryakov
Comment 3 2011-10-06 10:04:11 PDT
Note You need to log in before you can comment on or make changes to this bug.