Bug 69491 - Define a log2f() function for Windows in wtf/MathExtras.h
Summary: Define a log2f() function for Windows in wtf/MathExtras.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-05 17:40 PDT by Chris Rogers
Modified: 2011-10-05 19:03 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.54 KB, patch)
2011-10-05 17:42 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-10-05 17:40:10 PDT
Define a log2f() function for Windows in wtf/MathExtras.h
Comment 1 Chris Rogers 2011-10-05 17:42:11 PDT
Created attachment 109893 [details]
Patch
Comment 2 Darin Adler 2011-10-05 17:50:00 PDT
Comment on attachment 109893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109893&action=review

> Source/JavaScriptCore/wtf/MathExtras.h:162
> +    return logf(num) / 0.693147180559945309417232121458176568f;

Probably don’t need quite this many digits, but since I don’t know how many we do need, guess we should leave it like this.
Comment 3 WebKit Review Bot 2011-10-05 19:03:27 PDT
Comment on attachment 109893 [details]
Patch

Clearing flags on attachment: 109893

Committed r96780: <http://trac.webkit.org/changeset/96780>
Comment 4 WebKit Review Bot 2011-10-05 19:03:31 PDT
All reviewed patches have been landed.  Closing bug.