Bug 69485 - BiquadFilterNode must not reset filter state if type attribute is set to the same type
Summary: BiquadFilterNode must not reset filter state if type attribute is set to the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-05 17:26 PDT by Chris Rogers
Modified: 2011-10-06 12:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2011-10-05 17:28 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-10-05 17:26:41 PDT 
BiquadFilterNode must not reset filter state if type attribute is set to the same type
Comment 1 Chris Rogers 2011-10-05 17:28:28 PDT 
Created attachment 109888 [details]
Patch
Comment 2 Chris Rogers 2011-10-05 17:32:25 PDT 
http://trac.webkit.org/changeset/96525

is causing glitches in some cases because a BiquadFilterNode .type attribute is set redundantly (to the same value multiple times) in some web audio pages.  When this happens, the filter state is being reset (causing the glitch).  The filter state should only be reset if the filter type is actually changing to a different type, in which case it is appropriate.
Comment 3 Kenneth Russell 2011-10-06 11:33:43 PDT 
Comment on attachment 109888 [details]
Patch

Looks OK.
Comment 4 WebKit Review Bot 2011-10-06 12:19:52 PDT 
Comment on attachment 109888 [details]
Patch

Clearing flags on attachment: 109888

Committed r96846: <http://trac.webkit.org/changeset/96846>
Comment 5 WebKit Review Bot 2011-10-06 12:19:56 PDT 
All reviewed patches have been landed.  Closing bug.