WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 69478
Add explicit JSGlobalThis type.
https://bugs.webkit.org/show_bug.cgi?id=69478
Summary
Add explicit JSGlobalThis type.
Gavin Barraclough
Reported
2011-10-05 16:19:34 PDT
JSC supports a spilt global object, as used by WebCore for the Window. As a stage of making this visible to JSC, make it so that if the global this value is not the global object itself, it must be a subclass of JSGlobalThis.
Attachments
The patch
(18.70 KB, patch)
2011-10-05 16:42 PDT
,
Gavin Barraclough
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2011-10-05 16:42:11 PDT
Created
attachment 109879
[details]
The patch
Darin Adler
Comment 2
2011-10-05 16:57:57 PDT
Comment on
attachment 109879
[details]
The patch View in context:
https://bugs.webkit.org/attachment.cgi?id=109879&action=review
> Source/JavaScriptCore/ChangeLog:8 > + > + JSC supports a spilt global object, as used by WebCore for the Window. As a stage
Typo: spilt
> Source/JavaScriptCore/runtime/JSGlobalObject.h:-171 > - putThisToAnonymousValue(0);
Patch won’t apply because Oliver just removed this in another patch.
Gavin Barraclough
Comment 3
2011-10-06 11:16:54 PDT
Fixed in
r96836
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug