RESOLVED FIXED 69473
Fix Windows build - it doesn't have a log2f() function... 
https://bugs.webkit.org/show_bug.cgi?id=69473
Summary Fix Windows build - it doesn't have a log2f() function...
Chris Rogers
Reported 2011-10-05 15:40:18 PDT
Fix Windows build - it doesn't have a log2f() function...
Attachments
Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-10-05 15:48:06 PDT
Committed r96761: <http://trac.webkit.org/changeset/96761>
Adam Roben (:aroben)
Comment 2 2011-10-05 15:50:18 PDT
Another option is to add a log2f function to wtf/MathExtras.h for Windows to use.
Darin Adler
Comment 3 2011-10-05 16:03:02 PDT
In the past we have fixed problems like this by adding functions to MathExtras.h to smooth over differences between what platforms have in their <math.h> headers.
Adam Roben (:aroben)
Comment 4 2011-10-05 16:16:28 PDT
Darin is like my much more eloquent shadow.
Darin Adler
Comment 5 2011-10-05 16:32:09 PDT
Next time I will read before I write, because Adam is sure to get there first ;-)
Chris Rogers
Comment 6 2011-10-05 16:40:03 PDT
Yes, this was certainly a quick fix. I wanted to get the chromium win builders happy ASAP. The real fix for my code is not to use the log2() functions at all since they're inefficient. There's a much better algorithm for what I'm doing there (exponential ramp).
Chris Rogers
Comment 7 2011-10-05 16:40:52 PDT
In the meantime, I'll try to fix this as you suggest.
Note You need to log in before you can comment on or make changes to this bug.