Bug 69473 - Fix Windows build - it doesn't have a log2f() function...
Summary: Fix Windows build - it doesn't have a log2f() function...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-05 15:40 PDT by Chris Rogers
Modified: 2011-10-05 16:40 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-10-05 15:40:18 PDT 
Fix Windows build - it doesn't have a log2f() function...
Comment 1 Chris Rogers 2011-10-05 15:48:06 PDT 
Committed r96761: <http://trac.webkit.org/changeset/96761>
Comment 2 Adam Roben (:aroben) 2011-10-05 15:50:18 PDT 
Another option is to add a log2f function to wtf/MathExtras.h for Windows to use.
Comment 3 Darin Adler 2011-10-05 16:03:02 PDT 
In the past we have fixed problems like this by adding functions to MathExtras.h to smooth over differences between what platforms have in their <math.h> headers.
Comment 4 Adam Roben (:aroben) 2011-10-05 16:16:28 PDT 
Darin is like my much more eloquent shadow.
Comment 5 Darin Adler 2011-10-05 16:32:09 PDT 
Next time I will read before I write, because Adam is sure to get there first ;-)
Comment 6 Chris Rogers 2011-10-05 16:40:03 PDT 
Yes, this was certainly a quick fix.  I wanted to get the chromium win builders happy ASAP.

The real fix for my code is not to use the log2() functions at all since they're inefficient.  There's a much better algorithm for what I'm doing there (exponential ramp).
Comment 7 Chris Rogers 2011-10-05 16:40:52 PDT 
In the meantime, I'll try to fix this as you suggest.