Bug 69463 - Improve the watchlist for threading entries.
Summary: Improve the watchlist for threading entries.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-05 13:55 PDT by David Levin
Modified: 2011-10-14 14:19 PDT (History)
0 users

See Also:


Attachments
Patch (2.50 KB, patch)
2011-10-05 13:58 PDT, David Levin
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-10-05 13:55:39 PDT
Exclude files from the more match and add more files and patterns.
Comment 1 David Levin 2011-10-05 13:58:13 PDT
Created attachment 109857 [details]
Patch
Comment 2 Adam Barth 2011-10-05 14:12:35 PDT
Comment on attachment 109857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109857&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:23
> +            "more": r"(AllowCrossThreadAccess|AtomicallyInitialize|CrossThreadCopier|CrossThreadRefCounted|Mutex|ReadWriteLock|ThreadCondition|ThreadSafeRefCounted|ThreadSpecific"
> +                    r"|createCallbackTask|crossThreadString|deprecatedTurnOffVerifier|threadsafeCopy|)(?!\.(h|cpp))",

Is the trailing | intentional?
Comment 3 David Levin 2011-10-05 16:44:44 PDT
(In reply to comment #2)
> (From update of attachment 109857 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109857&action=review
> 
> > Tools/Scripts/webkitpy/common/config/watchlist:23
> > +            "more": r"(AllowCrossThreadAccess|AtomicallyInitialize|CrossThreadCopier|CrossThreadRefCounted|Mutex|ReadWriteLock|ThreadCondition|ThreadSafeRefCounted|ThreadSpecific"
> > +                    r"|createCallbackTask|crossThreadString|deprecatedTurnOffVerifier|threadsafeCopy|)(?!\.(h|cpp))",
> 
> Is the trailing | intentional?

No, that's not good. :) I'll fix it on check in.
Comment 4 David Levin 2011-10-14 14:19:34 PDT
Committed as http://trac.webkit.org/changeset/96768