RESOLVED FIXED69458
Make destructor of WebURLLoaderClient virtual. 
https://bugs.webkit.org/show_bug.cgi?id=69458
Summary Make destructor of WebURLLoaderClient virtual.
asvitkine
Reported 2011-10-05 13:25:51 PDT
Fix memory leak with WebURLLoaderClient.
Attachments
Patch (1.23 KB, patch)
2011-10-05 13:26 PDT, asvitkine 		no flags
DetailsFormatted DiffDiff
Patch (1.13 KB, patch)
2011-10-05 13:59 PDT, asvitkine 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
asvitkine
Comment 1 2011-10-05 13:26:13 PDT
Created attachment 109847 [details] Patch
asvitkine
Comment 2 2011-10-05 13:27:42 PDT
Patch on behalf of Roger Tawa (rogerta@chromium.org)
WebKit Review Bot
Comment 3 2011-10-05 13:28:28 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 4 2011-10-05 13:40:40 PDT
Comment on attachment 109847 [details] Patch can you explain why we need this? since the destructor is protected, no one should be deleting a WebURLLoaderClient pointer.
asvitkine
Comment 5 2011-10-05 13:55:18 PDT
(In reply to comment #0) > Fix memory leak with WebURLLoaderClient. Sorry, I was submitting this on behalf of Roger without understanding the full context - this specific change doesn't fix the leak - it's a code cleanup item. I'll update the ChangeLog description in the patch momentarily. (In reply to comment #4) > (From update of attachment 109847 [details]) > can you explain why we need this? since the destructor is protected, no one should be deleting a WebURLLoaderClient pointer. The motivation for this is that WebURLLoaderClient is basically an interface with a bunch of virtual methods, so its destructor should also be virtual. For example, one could make a derived class that implements the interface and deletes instances of itself through a WebURLLoaderClient pointer (which is legal since the destructor is protected), which wouldn't work correctly without this change.
asvitkine
Comment 6 2011-10-05 13:59:07 PDT
Created attachment 109858 [details] Patch
Darin Fisher (:fishd, Google)
Comment 7 2011-10-05 16:53:41 PDT
Comment on attachment 109858 [details] Patch OK
WebKit Review Bot
Comment 8 2011-10-05 17:33:20 PDT
Comment on attachment 109858 [details] Patch Clearing flags on attachment: 109858 Committed r96772: <http://trac.webkit.org/changeset/96772>
WebKit Review Bot
Comment 9 2011-10-05 17:33:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.