Bug 69450 – [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Raphael Kubo da Costa (:rakuco)]

[EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 109833 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 109833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109833&action=review

It'll be nice if the logic to obtain the temp dir. was extracted as a function.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:403
> +    char* tempDir = getenv("TMPDIR");

You should use const char* instead.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:409
> +    else {
> +        tempDir = getenv("TEMP");
> +        if (tempDir)

You should define the variable inside if as in:
else if (tempDir = getenv("TEMP"))

[Raphael Kubo da Costa (:rakuco)]

Created attachment 109986 [details]
Follow rniwa's suggestions

[Ryosuke Niwa]

Comment on attachment 109986 [details]
Follow rniwa's suggestions

View in context: https://bugs.webkit.org/attachment.cgi?id=109986&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:408
> +    else {
> +        if (tempDir = getenv("TEMP"))

Please use else if instead of nesting like this.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 109988 [details]
Er, no need to ask for review again. List rniwa as the reviewer

[Ryosuke Niwa]

Comment on attachment 109988 [details]
Er, no need to ask for review again. List rniwa as the reviewer

View in context: https://bugs.webkit.org/attachment.cgi?id=109988&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:408
> +    else {
> +        if (tempDir = getenv("TEMP"))

Please fix this before landing it.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 109990 [details]
Follow rniwa's new suggestion

[WebKit Review Bot]

Comment on attachment 109990 [details]
Follow rniwa's new suggestion

Clearing flags on attachment: 109990

Committed r96848: <http://trac.webkit.org/changeset/96848>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.