Bug 69432 - [Qt][WK2][Mac] QtWebProcess should not show up in the Dock.
Summary: [Qt][WK2][Mac] QtWebProcess should not show up in the Dock.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-05 08:53 PDT by Zeno Albisser
Modified: 2011-10-06 04:22 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2011-10-05 08:57 PDT, Zeno Albisser 		kling: review-
Details | Formatted Diff | Diff
patch for review. - dropped the toLocal8Bit() thing. (1.33 KB, patch)
2011-10-05 13:57 PDT, Zeno Albisser 		kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
patch for review - fixed "#if defined(X)" (1.70 KB, patch)
2011-10-06 03:56 PDT, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2011-10-05 08:53:21 PDT 
[Qt][WK2][Mac] QtWebProcess should not show up in the Dock.
Comment 1 Zeno Albisser 2011-10-05 08:57:31 PDT 
Created attachment 109807 [details]
Patch
Comment 2 Andreas Kling 2011-10-05 09:09:23 PDT 
Comment on attachment 109807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109807&action=review

Very nice! :)

> Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:85
> +    qputenv("QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM", QString("1").toLocal8Bit());

We can avoid invoking the ASCII codec by simply passing QByteArray("1") for the second argument.
Comment 3 Zeno Albisser 2011-10-05 13:57:18 PDT 
Created attachment 109856 [details]
patch for review. - dropped the toLocal8Bit() thing.
Comment 4 Andreas Kling 2011-10-05 14:30:28 PDT 
Comment on attachment 109856 [details]
patch for review. - dropped the toLocal8Bit() thing.

View in context: https://bugs.webkit.org/attachment.cgi?id=109856&action=review

r=me

> Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:84
> +#if defined Q_OS_MACX

I don't think I've ever seen "#if defined X" in WebKit before, let's stick with "#ifdef X" or "#if defined(X)". Sorry I didn't notice earlier.
Comment 5 Zeno Albisser 2011-10-06 03:56:12 PDT 
Created attachment 109941 [details]
patch for review - fixed "#if defined(X)"
Comment 6 WebKit Review Bot 2011-10-06 04:22:19 PDT 
Comment on attachment 109941 [details]
patch for review - fixed "#if defined(X)"

Clearing flags on attachment: 109941

Committed r96800: <http://trac.webkit.org/changeset/96800>
Comment 7 WebKit Review Bot 2011-10-06 04:22:23 PDT 
All reviewed patches have been landed.  Closing bug.