Bug 69428 - Web Inspector: debugger-activation-crash2.html are flaky.
Summary: Web Inspector: debugger-activation-crash2.html are flaky.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-05 08:15 PDT by Ilya Tikhonovsky
Modified: 2011-10-05 09:09 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.35 KB, patch)
2011-10-05 08:18 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (4.12 KB, patch)
2011-10-05 08:53 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-10-05 08:15:20 PDT
The breakpoint position depends on mode of javascript engine.
Comment 1 Ilya Tikhonovsky 2011-10-05 08:18:32 PDT
Created attachment 109796 [details]
Patch
Comment 2 Yury Semikhatsky 2011-10-05 08:37:27 PDT
Comment on attachment 109796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109796&action=review

> LayoutTests/inspector/debugger/debugger-activation-crash2.html:-37
> -        InspectorTest.setBreakpoint(sourceFrame, 8, "", true);

I'd rather remove line numbers from the output. This would fix the flakiness.
Comment 3 Ilya Tikhonovsky 2011-10-05 08:53:55 PDT
Created attachment 109806 [details]
Patch
Comment 4 Ilya Tikhonovsky 2011-10-05 09:09:02 PDT
Committed r96709: <http://trac.webkit.org/changeset/96709>