Bug 69422 - Web Inspector: provide a way for persisting worker inspector state
Summary: Web Inspector: provide a way for persisting worker inspector state
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
Depends on: 69434
  Show dependency treegraph
Reported: 2011-10-05 07:24 PDT by Yury Semikhatsky
Modified: 2011-10-05 09:32 PDT (History)
13 users (show)

See Also:

Patch (26.97 KB, patch)
2011-10-05 08:32 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-10-05 07:24:48 PDT
Worker inspector may have a state(e.g. breakpoints) that should be restored when inspected worker restarts.
Comment 1 Yury Semikhatsky 2011-10-05 08:32:09 PDT
Created attachment 109800 [details]
Comment 2 WebKit Review Bot 2011-10-05 08:35:52 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Yury Semikhatsky 2011-10-05 09:10:25 PDT
Committed r96710: <http://trac.webkit.org/changeset/96710>
Comment 4 Csaba Osztrogonác 2011-10-05 09:31:05 PDT
Comment on attachment 109800 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=109800&action=review

> Source/WebCore/inspector/WorkerInspectorController.cpp:197
> +    ASSERT(!m_inspectorFrontend);

It broke debug builds: 
../../../Source/WebCore/inspector/WorkerInspectorController.cpp: In member function 'void WebCore::WorkerInspectorController::restoreInspectorStateFromCookie(const WTF::String&)':
../../../Source/WebCore/inspector/WorkerInspectorController.cpp:197:5: error: 'm_inspectorFrontend' was not declared in this scope
Comment 5 Csaba Osztrogonác 2011-10-05 09:32:08 PDT
Oh, fix landed in http://trac.webkit.org/changeset/96713