Bug 69400 – REGRESSION(r53878): Input elements don't share their styles if the document contains no validity style rules.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Kent Tamura]

http://trac.webkit.org/changeset/53878 introduced an optimization to avoid form control validation.

               if (!m_element->document()->containsValidityStyleRules()) 
 	                return false; 
 
However, this code means that we don't share input element styles if the document contains no validity style rules.

[Andreas Kling]

Created attachment 126246 [details]
Patch

[Kent Tamura]

Comment on attachment 126246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126246&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:1188
>      if (element->isInRange() != m_element->isInRange())
>          return false;

isInRange and isOutOfRange also belong to validity style rules. See SelectorChecker.cpp.

[Andreas Kling]

Created attachment 126254 [details]
Patch v2

Even less work in the common case, then  :)

[Andreas Kling]

Comment on attachment 126254 [details]
Patch v2

Clearing flags on attachment: 126254

Committed r107193: <http://trac.webkit.org/changeset/107193>

[Andreas Kling]

All reviewed patches have been landed.  Closing bug.