Bug 69396 - In WebKitTestRunner, text has font smoothing in pixel snapshots
Summary: In WebKitTestRunner, text has font smoothing in pixel snapshots
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2011-10-04 21:04 PDT by Simon Fraser (smfr)
Modified: 2011-10-05 17:08 PDT (History)
4 users (show)

See Also:

Patch (2.22 KB, patch)
2011-10-04 21:23 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (12.88 KB, patch)
2011-10-05 13:31 PDT, Simon Fraser (smfr)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-10-04 21:04:22 PDT
Pixel results from WebKitTestRunner show that font smoothing is enabled, resulting in lots of spurious text differences.
Comment 1 Radar WebKit Bug Importer 2011-10-04 21:06:20 PDT
Comment 2 Simon Fraser (smfr) 2011-10-04 21:23:14 PDT
Created attachment 109743 [details]
Comment 3 mitz 2011-10-04 21:39:36 PDT
Comment on attachment 109743 [details]

WebKit preferences should not be used to set globals. Unfortunately on the Windows port, this preference already has this incorrect behavior. Moving forward, we need to deprecate it (which is easy since it’s in a private header), not add incorrect implementations on other platforms.
Comment 4 Simon Fraser (smfr) 2011-10-05 13:31:12 PDT
Created attachment 109850 [details]
Comment 5 Darin Adler 2011-10-05 13:39:58 PDT
Comment on attachment 109850 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=109850&action=review

> Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:53
> +WK_EXPORT void _WKContextSetShouldUseFontSmoothing(WKContextRef context, bool useFontSmoothing);

What’s the deal with these underscore prefixes?
Comment 6 Simon Fraser (smfr) 2011-10-05 13:41:02 PDT
(In reply to comment #5)
> What’s the deal with these underscore prefixes?

No idea. Some methods have them, some do not.
Comment 7 Darin Adler 2011-10-05 15:39:48 PDT
Comment on attachment 109850 [details]

I don’t understand the motivation for the underscore prefix in _WKContextSetShouldUseFontSmoothing, but this patch seems otherwise great.
Comment 8 Simon Fraser (smfr) 2011-10-05 17:08:23 PDT