Bug 69391 - [chromium] Expose threaded compositor via a runtime setting
Summary: [chromium] Expose threaded compositor via a runtime setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 18:19 PDT by Vangelis Kokkevis
Modified: 2011-10-05 16:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.38 KB, patch)
2011-10-04 23:01 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
Patch (14.87 KB, patch)
2011-10-05 13:18 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
Patch (14.89 KB, patch)
2011-10-05 15:33 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2011-10-04 18:19:40 PDT 
Threaded compositor is currently behind a compile time flag which makes it awkward to switch between threaded and non-threaded modes.
Comment 1 Vangelis Kokkevis 2011-10-04 23:01:00 PDT 
Created attachment 109746 [details]
Patch
Comment 2 Vangelis Kokkevis 2011-10-05 13:18:11 PDT 
Created attachment 109845 [details]
Patch
Comment 3 WebKit Review Bot 2011-10-05 13:21:51 PDT 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 WebKit Review Bot 2011-10-05 15:10:04 PDT 
Comment on attachment 109845 [details]
Patch

Rejecting attachment 109845 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
24aaab553fd1b1cc1d4479459a38aa671b28fbd3
r96756 = 6ca3323c04544b200ce5f60627ce3afca52b5e5c
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9968045
Comment 5 Vangelis Kokkevis 2011-10-05 15:33:30 PDT 
Created attachment 109873 [details]
Patch
Comment 6 WebKit Review Bot 2011-10-05 15:34:57 PDT 
Comment on attachment 109873 [details]
Patch

Rejecting attachment 109873 [details] from review queue.

vangelis@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 7 WebKit Review Bot 2011-10-05 16:45:30 PDT 
Comment on attachment 109873 [details]
Patch

Clearing flags on attachment: 109873

Committed r96766: <http://trac.webkit.org/changeset/96766>
Comment 8 WebKit Review Bot 2011-10-05 16:45:34 PDT 
All reviewed patches have been landed.  Closing bug.