Bug 69389 - Mask underlying RENDERER and VENDOR strings
Summary: Mask underlying RENDERER and VENDOR strings
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
Depends on:
Reported: 2011-10-04 18:11 PDT by Kenneth Russell
Modified: 2011-10-05 11:06 PDT (History)
6 users (show)

See Also:

Patch (6.54 KB, patch)
2011-10-04 18:21 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-10-04 18:11:55 PDT
After extensive discussion in the WebGL working group, it appears that the consensus among browser vendors is that exposing the underlying GPU's GL_RENDERER and GL_VENDOR strings via WebGL is problematic. The reasons presented are twofold. First, they expose a certain number of bits of personally identifiable information. Second, they have similar properties to the browser's user-agent string, which has been an extremely problematic construct in the development of the web.

The plan is to stop reporting the underlying GPU's strings and instead report something generic, and to do so for all of WebKit's ports, to maintain parity.

It's possible this decision might be revisited in the future, but for the time being, this change seems necessary in order to match the behavior of Firefox and Opera.
Comment 1 Kenneth Russell 2011-10-04 18:21:16 PDT
Created attachment 109725 [details]
Comment 2 Sam Weinig 2011-10-04 20:09:34 PDT
Comment on attachment 109725 [details]

What is the point of exposing VENDOR or RENDERER at all?
Comment 3 Kenneth Russell 2011-10-05 10:16:08 PDT
(In reply to comment #2)
> (From update of attachment 109725 [details])
> What is the point of exposing VENDOR or RENDERER at all?

They're part of the OpenGL ES 2.0 specification, and an early design principle for WebGL was not to arbitrarily subset the API.

Some sophisticated applications also have wanted to change their behavior slightly based on the values of these strings to achieve the best performance on various graphics cards. The authors of these applications aren't happy that the real information will be masked, but we're still working toward a solution that works for everybody.
Comment 4 WebKit Review Bot 2011-10-05 11:06:28 PDT
Comment on attachment 109725 [details]

Clearing flags on attachment: 109725

Committed r96726: <http://trac.webkit.org/changeset/96726>
Comment 5 WebKit Review Bot 2011-10-05 11:06:32 PDT
All reviewed patches have been landed.  Closing bug.